Handling transition animation between non-interpolable values.

Handling transition animation between non-interpolable values.

In current transition animations, for any lengthsize css property
irrespective of interpolable values animation does start.
This patch will check whether the values are interpolable and decides
as follows:
i) If values are interpoable, start animation,
ii) else, hard set the respective length property to the element .
BUG=513127
Committed: https://crrev.com/4d344058522e01d85162fcd1a9e5f4b747db9383
Cr-Commit-Position: refs/heads/master@{#382801}

[Abhishek Kanike, 2016-02-25 13:54:23]

Description was changed from

==========
Handling transition animation between non-interpolable values.

In current transition animations, for any lengthsize css property
irrespective of interpolable values animation does start.
This patch will check whether the values are interpolable and decides
as follows:
i) If values are interpoable, start animation,
ii) else, hard set the respective length property to the element .
BUG=513217

Signed-off-by: abhishek.ka <abhishek.ka@samsung.com>
==========

to

==========
Handling transition animation between non-interpolable values.

In current transition animations, for any lengthsize css property
irrespective of interpolable values animation does start.
This patch will check whether the values are interpolable and decides
as follows:
i) If values are interpoable, start animation,
ii) else, hard set the respective length property to the element .
BUG=513217

Signed-off-by: abhishek.ka <abhishek.ka@samsung.com>
==========

[Abhishek Kanike, 2016-02-25 13:55:28]

abhishek.ka@samsung.com changed reviewers:
+ kphanee@chromium.org, sohanjg@chromium.org, vivekg@chromium.org

[Abhishek Kanike, 2016-02-26 06:43:20]

Description was changed from

==========
Handling transition animation between non-interpolable values.

In current transition animations, for any lengthsize css property
irrespective of interpolable values animation does start.
This patch will check whether the values are interpolable and decides
as follows:
i) If values are interpoable, start animation,
ii) else, hard set the respective length property to the element .
BUG=513217

Signed-off-by: abhishek.ka <abhishek.ka@samsung.com>
==========

to

==========
Handling transition animation between non-interpolable values.

In current transition animations, for any lengthsize css property
irrespective of interpolable values animation does start.
This patch will check whether the values are interpolable and decides
as follows:
i) If values are interpoable, start animation,
ii) else, hard set the respective length property to the element .
BUG=513217
==========

[alancutter (OOO until 2018), 2016-02-28 23:14:21]

alancutter@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2016-02-28 23:14:21]

Thanks for taking this one on.

The existing LayoutTest
animations/interpolation/background-size-interpolation.html should start passing
with this change and the failing expectations file can be deleted.

There's a typo in the bug number, it should be 513127.

https://codereview.chromium.org/1732323003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/animation/animatable/AnimatableLengthSize.cpp
(right):

https://codereview.chromium.org/1732323003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/animatable/AnimatableLengthSize.cpp:53:
|| usesDefaultInterpolation(this->height(), lengthSize->height());
"this->" is redundant and can be removed.

[Abhishek Kanike, 2016-03-17 13:53:33]

Description was changed from

==========
Handling transition animation between non-interpolable values.

In current transition animations, for any lengthsize css property
irrespective of interpolable values animation does start.
This patch will check whether the values are interpolable and decides
as follows:
i) If values are interpoable, start animation,
ii) else, hard set the respective length property to the element .
BUG=513217
==========

to

==========
Handling transition animation between non-interpolable values.

In current transition animations, for any lengthsize css property
irrespective of interpolable values animation does start.
This patch will check whether the values are interpolable and decides
as follows:
i) If values are interpoable, start animation,
ii) else, hard set the respective length property to the element .
BUG=513127
==========

[alancutter (OOO until 2018), 2016-03-22 09:01:37]

lgtm

https://codereview.chromium.org/1732323003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/interpolation/background-size-interpolation-expected.txt
(right):

https://codereview.chromium.org/1732323003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/interpolation/background-size-interpolation-expected.txt:12:
PASS CSS Transitions: property <background-size> from [initial] to [20px 20px,
0px 0px] at (0.3) is [20px 20px, 0px 0px, 20px 20px, 0px 0px]
Please delete this expectation file as there are no failing test cases any more.

[Abhishek Kanike, 2016-03-22 10:49:28]

On 2016/03/22 09:01:37, alancutter wrote:
> lgtm
> 
>
https://codereview.chromium.org/1732323003/diff/40001/third_party/WebKit/Layo...
> File
>
third_party/WebKit/LayoutTests/animations/interpolation/background-size-interpolation-expected.txt
> (right):
> 
>
https://codereview.chromium.org/1732323003/diff/40001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/animations/interpolation/background-size-interpolation-expected.txt:12:
> PASS CSS Transitions: property <background-size> from [initial] to [20px 20px,
> 0px 0px] at (0.3) is [20px 20px, 0px 0px, 20px 20px, 0px 0px]
> Please delete this expectation file as there are no failing test cases any
more.

Hi Alan,

I have deleted Expected file of background size interpolation layout test.

[Abhishek Kanike, 2016-03-22 11:01:23]

abhishek.ka@samsung.com changed reviewers:
+ dstockwell@chromium.org
- kphanee@chromium.org, sohanjg@chromium.org, vivekg@chromium.org

[alancutter (OOO until 2018), 2016-03-22 23:54:18]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-03-22 23:54:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/1732323003/#ps60001
(title: "Deleted Expected file of backgroudn size interpolation layout Test")

[commit-bot: I haz the power, 2016-03-22 23:54:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1732323003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1732323003/60001

[commit-bot: I haz the power, 2016-03-23 01:09:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 01:09:47]

Try jobs failed on following builders:
  linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)

[alancutter (OOO until 2018), 2016-03-23 03:08:14]

On 2016/03/23 at 01:09:47, commit-bot wrote:
> Try jobs failed on following builders:
>   linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)

Looks like you need to delete
animations/interpolation/webkit-mask-size-interpolation-expected.txt as well.

[Abhishek Kanike, 2016-03-23 05:20:11]

On 2016/03/23 03:08:14, alancutter wrote:
> On 2016/03/23 at 01:09:47, commit-bot wrote:
> > Try jobs failed on following builders:
> >   linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)
> 
> Looks like you need to delete
> animations/interpolation/webkit-mask-size-interpolation-expected.txt as well.

Done. Deleted
animations/interpolation/webkit-mask-size-interpolation-expected.txt as
tryserver was failing.

[alancutter (OOO until 2018), 2016-03-23 05:31:34]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-03-23 05:31:35]

lgtm

[commit-bot: I haz the power, 2016-03-23 05:31:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1732323003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1732323003/80001

[commit-bot: I haz the power, 2016-03-23 06:47:10]

Description was changed from

==========
Handling transition animation between non-interpolable values.

In current transition animations, for any lengthsize css property
irrespective of interpolable values animation does start.
This patch will check whether the values are interpolable and decides
as follows:
i) If values are interpoable, start animation,
ii) else, hard set the respective length property to the element .
BUG=513127
==========

to

==========
Handling transition animation between non-interpolable values.

In current transition animations, for any lengthsize css property
irrespective of interpolable values animation does start.
This patch will check whether the values are interpolable and decides
as follows:
i) If values are interpoable, start animation,
ii) else, hard set the respective length property to the element .
BUG=513127
==========

[commit-bot: I haz the power, 2016-03-23 06:47:11]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-23 06:48:49]

Description was changed from

==========
Handling transition animation between non-interpolable values.

In current transition animations, for any lengthsize css property
irrespective of interpolable values animation does start.
This patch will check whether the values are interpolable and decides
as follows:
i) If values are interpoable, start animation,
ii) else, hard set the respective length property to the element .
BUG=513127
==========

to

==========
Handling transition animation between non-interpolable values.

In current transition animations, for any lengthsize css property
irrespective of interpolable values animation does start.
This patch will check whether the values are interpolable and decides
as follows:
i) If values are interpoable, start animation,
ii) else, hard set the respective length property to the element .
BUG=513127

Committed: https://crrev.com/4d344058522e01d85162fcd1a9e5f4b747db9383
Cr-Commit-Position: refs/heads/master@{#382801}
==========

[commit-bot: I haz the power, 2016-03-23 06:48:50]

Patchset 5 (id:??) landed as
https://crrev.com/4d344058522e01d85162fcd1a9e5f4b747db9383
Cr-Commit-Position: refs/heads/master@{#382801}