Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: third_party/WebKit/Source/core/animation/animatable/AnimatableLengthSize.cpp

Issue 1732323003: Handling transition animation between non-interpolable values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: # Yet to run webkit layout tests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/animation/animatable/AnimatableLengthSize.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 28 matching lines...) Expand all
39 AnimatableValue::interpolate(this->width(), lengthSize->width(), fractio n), 39 AnimatableValue::interpolate(this->width(), lengthSize->width(), fractio n),
40 AnimatableValue::interpolate(this->height(), lengthSize->height(), fract ion)); 40 AnimatableValue::interpolate(this->height(), lengthSize->height(), fract ion));
41 } 41 }
42 42
43 bool AnimatableLengthSize::equalTo(const AnimatableValue* value) const 43 bool AnimatableLengthSize::equalTo(const AnimatableValue* value) const
44 { 44 {
45 const AnimatableLengthSize* lengthSize = toAnimatableLengthSize(value); 45 const AnimatableLengthSize* lengthSize = toAnimatableLengthSize(value);
46 return width()->equals(lengthSize->width()) && height()->equals(lengthSize-> height()); 46 return width()->equals(lengthSize->width()) && height()->equals(lengthSize-> height());
47 } 47 }
48 48
49 bool AnimatableLengthSize::usesDefaultInterpolationWith(const AnimatableValue* o ther) const
50 {
51 const AnimatableLengthSize* lengthSize = toAnimatableLengthSize(other);
52 return usesDefaultInterpolation(this->width(), lengthSize->width())
53 || usesDefaultInterpolation(this->height(), lengthSize->height());
alancutter (OOO until 2018) 2016/02/28 23:14:21 "this->" is redundant and can be removed.
54 }
55
49 } // namespace blink 56 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/animation/animatable/AnimatableLengthSize.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698