Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1732213002: Remove DataCompressionProxyDevRollout experiment (Closed)

Created:
4 years, 10 months ago by Raj
Modified:
4 years, 8 months ago
Reviewers:
tbansal1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DataCompressionProxyDevRollout experiment DataCompressionProxyDevRollout experiment is no longer used, so it should be removed. BUG=585198 Committed: https://crrev.com/23af05cf013c66f8b775d8cd4ee58c0767517797 Cr-Commit-Position: refs/heads/master@{#385500}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed tbansal comments #

Total comments: 2

Patch Set 3 : Addressed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -256 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc View 1 1 chunk +5 lines, -18 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc View 1 10 chunks +3 lines, -45 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc View 1 2 chunks +3 lines, -7 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params.h View 1 2 chunks +0 lines, -9 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc View 1 2 7 chunks +2 lines, -33 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.h View 1 3 chunks +0 lines, -8 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.cc View 1 3 chunks +0 lines, -21 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc View 1 2 2 chunks +13 lines, -71 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_switches.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc View 1 3 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Raj
ptal, thanks
4 years, 10 months ago (2016-02-25 19:32:48 UTC) #2
tbansal1
https://codereview.chromium.org/1732213002/diff/1/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc (left): https://codereview.chromium.org/1732213002/diff/1/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc#oldcode182 components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:182: if (command_line.HasSwitch(switches::kDisableDataReductionProxyDev)) Can this switch (and the one below) ...
4 years, 10 months ago (2016-02-25 20:31:22 UTC) #3
Raj
https://codereview.chromium.org/1732213002/diff/1/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc (left): https://codereview.chromium.org/1732213002/diff/1/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc#oldcode182 components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:182: if (command_line.HasSwitch(switches::kDisableDataReductionProxyDev)) On 2016/02/25 20:31:22, tbansal1 wrote: > Can ...
4 years, 8 months ago (2016-04-06 07:25:31 UTC) #4
tbansal1
lgtm % nit. Thanks for cleaning this up. https://codereview.chromium.org/1732213002/diff/20001/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc (right): https://codereview.chromium.org/1732213002/diff/20001/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc#newcode36 components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:36: const ...
4 years, 8 months ago (2016-04-06 16:33:49 UTC) #5
Raj
thanks https://codereview.chromium.org/1732213002/diff/20001/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc (right): https://codereview.chromium.org/1732213002/diff/20001/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc#newcode36 components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:36: const char kDevOrigin[] = "https://proxy-dev.googlezip.net:443"; On 2016/04/06 16:33:49, ...
4 years, 8 months ago (2016-04-06 17:29:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732213002/40001
4 years, 8 months ago (2016-04-06 17:29:49 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-06 17:44:23 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 17:45:42 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/23af05cf013c66f8b775d8cd4ee58c0767517797
Cr-Commit-Position: refs/heads/master@{#385500}

Powered by Google App Engine
This is Rietveld 408576698