components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc - Issue 1732213002: Remove DataCompressionProxyDevRollout experiment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc

Issue 1732213002: Remove DataCompressionProxyDevRollout experiment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed nits Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/about_flags.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc

index 2fda7a2f9e6c27a8cf8206973fe7394d51b80d39..1c222b0f53ce1f0762f393e4b5eb194e210681a8 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc

@@ -472,16 +472,6 @@ bool DataReductionProxyConfigServiceClient::ParseAndApplyProxyConfig(

std::vector<net::ProxyServer> proxies =

GetProxiesForHTTP(config.proxy_config());

- if (params_ && params::IsDevRolloutEnabled()) {

- // If dev rollout is enabled, proxies returned by client config API are

- // discarded.

- proxies.clear();

- proxies.push_back(net::ProxyServer::FromURI(params_->GetDefaultDevOrigin(),

- net::ProxyServer::SCHEME_HTTP));

- proxies.push_back(net::ProxyServer::FromURI(

- params_->GetDefaultDevFallbackOrigin(), net::ProxyServer::SCHEME_HTTP));

- }

if (proxies.empty())

return false;