Update strings to match the final spec.

Update strings to match the final spec.

Update strings, images, and UI to match final versions approved by UX, and
include the custodian's name where applicable. Remove references to
"limited users" in the code -- we don't need even more name fragmentation.

The custodian's name is not yet collected, but we fall back to the email
address if we don't have it.

TBR=sail@chromium.org
TBR=kalman@chromium.org

BUG=248859, 252212
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207943

[Pam (message me for reviews), 2013-06-20 15:08:08]

Sergiu: please review
Bernhard, Adrian: FYI

I want to make the link in the confirmation step clickable, but it's nontrivial
while still including a user-supplied profile name in the same string. I'll work
on that piece tomorrow, but let's get the rest in in the meantime.

- Pam

[Bernhard Bauer, 2013-06-20 15:20:35]

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:14979: +      A supervised user named <ph
name="NEW_PROFILE_NAME">$1<ex>New User</ex></ph> has been created. To set which
websites the supervised user can view, you can configure restrictions and
settings by visiting www.chrome.com/manage. If you do not change the default
settings, <ph name="NEW_PROFILE_NAME_2">$2<ex>New User</ex></ph> can browse all
sites on the web.
Do we need two placeholders for the managed user's name in here?

https://codereview.chromium.org/17320005/diff/33004/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/managed_user_create_confirm_handler.cc
(right):

https://codereview.chromium.org/17320005/diff/33004/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/managed_user_create_confirm_handler.cc:37: {
"managedUserCreateConfirmTitle", IDS_NEW_MANAGED_USER_SUCCESS_TITLE },
I think it would make things easier if the strings matched the IDs.

[Sergiu, 2013-06-20 15:54:56]

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
File chrome/app/generated_resources.grd (left):

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:5614: <message
name="IDS_EXTENSIONS_LOCKED_MANAGED_MODE" desc="The error message (either shown
in the extensions UI or logged) informing the user that extensions are
controlled by managed mode">
Update description as well.

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:6883: <message
name="IDS_FLAGS_ENABLE_LOCALLY_MANAGED_USERS_NAME" desc="Title for the flag to
enable locally managed users.">
Update description as well.

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:8368: <message
name="IDS_BLOCK_INTERSTITIAL_MESSAGE" desc="A message for the user when they
attempt to visit a site outside of any content pack.">
Since we don't have content packs now I'd change this description text as well.

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:11701: Switch Users
Lowercase u?

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:14912: +      Visited websites and settings
for this supervised user may still be visible by the manager at
www.chrome.com/manage.
Shouldn't this be a link here?

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:14961: +    <message
name="IDS_NEW_MANAGED_USER_LEARN_MORE_TEXT" desc="Informative text describing
the 'supervised user' feature in detail, shown when the 'Learn more' link is
clicked in the 'Create User' dialog. The HTML entities at the starts of the
lines are a bullet and a non-breaking space.">
"starts of the lines" sounds odd to me with "starts" in plural :)

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:14962: +      A supervised user can explore
the web with your guidance. As the manager of a supervised user in Chrome, you
can
Colon at the end

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:14970: +After you create a new supervised
user, you can manage their settings at any time, from any device, at
www.chrome.com/manage.
Again, link.

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:14979: +      A supervised user named <ph
name="NEW_PROFILE_NAME">$1<ex>New User</ex></ph> has been created. To set which
websites the supervised user can view, you can configure restrictions and
settings by visiting www.chrome.com/manage. If you do not change the default
settings, <ph name="NEW_PROFILE_NAME_2">$2<ex>New User</ex></ph> can browse all
sites on the web.
Link.

https://codereview.chromium.org/17320005/diff/33004/chrome/browser/resources/...
File chrome/browser/resources/options/managed_user_create_confirm.css (left):

https://codereview.chromium.org/17320005/diff/33004/chrome/browser/resources/...
chrome/browser/resources/options/managed_user_create_confirm.css:17: 
P(code_that_I_write_gets_deleted) ~= 1 :)

https://codereview.chromium.org/17320005/diff/33004/chrome/browser/resources/...
chrome/browser/resources/options/managed_user_create_confirm.css:23:
background-image: url('managed_user_create_confirm_1.png');
Don't forget to remove these images as well.

https://codereview.chromium.org/17320005/diff/33004/chrome/common/pref_names.h
File chrome/common/pref_names.h (right):

https://codereview.chromium.org/17320005/diff/33004/chrome/common/pref_names....
chrome/common/pref_names.h:27: extern const char kManagedUserCustodianName[];
I did a search, where do we actually set this?

[Bernhard Bauer, 2013-06-20 16:17:35]

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
File chrome/app/generated_resources.grd (left):

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:11701: Switch Users
On 2013/06/20 15:54:56, Sergiu wrote:
> Lowercase u?

It depends on the platform, actually. Gtk and Mac-ish platforms (OS X, iOS) use
Title Case, others use Sentence case. You can use <if
expr="pp_ifdef('use_titlecase')"> to differentiate.

[Pam (message me for reviews), 2013-06-20 20:26:40]

New patch! Yay! PTAL.

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:14912: +      Visited websites and settings
for this supervised user may still be visible by the manager at
www.chrome.com/manage.
On 2013/06/20 15:54:56, Sergiu wrote:
> Shouldn't this be a link here?

It's only useful if the person deleting the profile is the manager, but sure.

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:14961: +    <message
name="IDS_NEW_MANAGED_USER_LEARN_MORE_TEXT" desc="Informative text describing
the 'supervised user' feature in detail, shown when the 'Learn more' link is
clicked in the 'Create User' dialog. The HTML entities at the starts of the
lines are a bullet and a non-breaking space.">
On 2013/06/20 15:54:56, Sergiu wrote:
> "starts of the lines" sounds odd to me with "starts" in plural :)

And yet, there are multiple lines, each with its own start, so it's correct. :-)

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:14962: +      A supervised user can explore
the web with your guidance. As the manager of a supervised user in Chrome, you
can
On 2013/06/20 15:54:56, Sergiu wrote:
> Colon at the end

A colon introduces a list that follows a complete independent clause, but not
one that follows a partial clause (for example, a transitive verb with no
object, or -- as here -- an auxiliary verb with no main verb). See for example
https://plus.sandbox.google.com/109746151709791743509/posts/EsxRYKqqA41  :)
or if you prefer,
http://grammar.ccc.commnet.edu/grammar/marks/colon.htm

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:14970: +After you create a new supervised
user, you can manage their settings at any time, from any device, at
www.chrome.com/manage.
On 2013/06/20 15:54:56, Sergiu wrote:
> Again, link.

This one was omitted on purpose. We don't want to distract people into wandering
off while they're in the middle of creating a new user, and the dashboard won't
be very useful to them for this user until they've created it anyway.

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:14979: +      A supervised user named <ph
name="NEW_PROFILE_NAME">$1<ex>New User</ex></ph> has been created. To set which
websites the supervised user can view, you can configure restrictions and
settings by visiting www.chrome.com/manage. If you do not change the default
settings, <ph name="NEW_PROFILE_NAME_2">$2<ex>New User</ex></ph> can browse all
sites on the web.
On 2013/06/20 15:20:35, Bernhard Bauer wrote:
> Do we need two placeholders for the managed user's name in here?

I guess not. I hadn't realized it's a global search-and-replace, as opposed to
printf-like formatting.

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:14979: +      A supervised user named <ph
name="NEW_PROFILE_NAME">$1<ex>New User</ex></ph> has been created. To set which
websites the supervised user can view, you can configure restrictions and
settings by visiting www.chrome.com/manage. If you do not change the default
settings, <ph name="NEW_PROFILE_NAME_2">$2<ex>New User</ex></ph> can browse all
sites on the web.
On 2013/06/20 15:54:56, Sergiu wrote:
> Link.

See my first comment on the CL.  I want to turn this into a link, but I can't
set the innerHTML with user-supplied strings (the new profile's name) without
sanitizing them. I'll work on that tomorrow.

https://codereview.chromium.org/17320005/diff/33004/chrome/browser/resources/...
File chrome/browser/resources/options/managed_user_create_confirm.css (left):

https://codereview.chromium.org/17320005/diff/33004/chrome/browser/resources/...
chrome/browser/resources/options/managed_user_create_confirm.css:17: 
On 2013/06/20 15:54:56, Sergiu wrote:
> P(code_that_I_write_gets_deleted) ~= 1 :)

Yeah, sorry. :( It was a very cool carousel!

https://codereview.chromium.org/17320005/diff/33004/chrome/common/pref_names.h
File chrome/common/pref_names.h (right):

https://codereview.chromium.org/17320005/diff/33004/chrome/common/pref_names....
chrome/common/pref_names.h:27: extern const char kManagedUserCustodianName[];
On 2013/06/20 15:54:56, Sergiu wrote:
> I did a search, where do we actually set this?

We don't yet. I have a patch that tries to, which I haven't been able to test
because of server issues, but I'll be doing that tomorrow. See the description
of this CL.

You can actually see that code (compiled, but never run) up in Patch Set 2 in
this issue.

[Sergiu, 2013-06-20 21:47:46]

LGTM, don't forget to remove the 3 placeholder images, although you can do it in
another CL.

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:14912: +      Visited websites and settings
for this supervised user may still be visible by the manager at
www.chrome.com/manage.
On 2013/06/20 20:26:40, Pam - also send IM for reviews wrote:
> On 2013/06/20 15:54:56, Sergiu wrote:
> > Shouldn't this be a link here?
> 
> It's only useful if the person deleting the profile is the manager, but sure.

Can't hurt I guess, although I don't think a lot of people will see this message
anyway.

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:14961: +    <message
name="IDS_NEW_MANAGED_USER_LEARN_MORE_TEXT" desc="Informative text describing
the 'supervised user' feature in detail, shown when the 'Learn more' link is
clicked in the 'Create User' dialog. The HTML entities at the starts of the
lines are a bullet and a non-breaking space.">
On 2013/06/20 20:26:40, Pam - also send IM for reviews wrote:
> On 2013/06/20 15:54:56, Sergiu wrote:
> > "starts of the lines" sounds odd to me with "starts" in plural :)
> 
> And yet, there are multiple lines, each with its own start, so it's correct.
:-)

Got it ! :)

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:14962: +      A supervised user can explore
the web with your guidance. As the manager of a supervised user in Chrome, you
can
On 2013/06/20 20:26:40, Pam - also send IM for reviews wrote:
> On 2013/06/20 15:54:56, Sergiu wrote:
> > Colon at the end
> 
> A colon introduces a list that follows a complete independent clause, but not
> one that follows a partial clause (for example, a transitive verb with no
> object, or -- as here -- an auxiliary verb with no main verb). See for example
> https://plus.sandbox.google.com/109746151709791743509/posts/EsxRYKqqA41  :)
> or if you prefer,
> http://grammar.ccc.commnet.edu/grammar/marks/colon.htm

Got it, popped out more because there was one in the approved list :).

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:14970: +After you create a new supervised
user, you can manage their settings at any time, from any device, at
www.chrome.com/manage.
On 2013/06/20 20:26:40, Pam - also send IM for reviews wrote:
> On 2013/06/20 15:54:56, Sergiu wrote:
> > Again, link.
> 
> This one was omitted on purpose. We don't want to distract people into
wandering
> off while they're in the middle of creating a new user, and the dashboard
won't
> be very useful to them for this user until they've created it anyway.

Sounds good to me.

https://codereview.chromium.org/17320005/diff/33004/chrome/app/generated_reso...
chrome/app/generated_resources.grd:14979: +      A supervised user named <ph
name="NEW_PROFILE_NAME">$1<ex>New User</ex></ph> has been created. To set which
websites the supervised user can view, you can configure restrictions and
settings by visiting www.chrome.com/manage. If you do not change the default
settings, <ph name="NEW_PROFILE_NAME_2">$2<ex>New User</ex></ph> can browse all
sites on the web.
On 2013/06/20 20:26:40, Pam - also send IM for reviews wrote:
> On 2013/06/20 15:54:56, Sergiu wrote:
> > Link.
> 
> See my first comment on the CL.  I want to turn this into a link, but I can't
> set the innerHTML with user-supplied strings (the new profile's name) without
> sanitizing them. I'll work on that tomorrow.

Got it, missed that initially.

https://codereview.chromium.org/17320005/diff/33004/chrome/common/pref_names.h
File chrome/common/pref_names.h (right):

https://codereview.chromium.org/17320005/diff/33004/chrome/common/pref_names....
chrome/common/pref_names.h:27: extern const char kManagedUserCustodianName[];
On 2013/06/20 20:26:40, Pam - also send IM for reviews wrote:
> On 2013/06/20 15:54:56, Sergiu wrote:
> > I did a search, where do we actually set this?
> 
> We don't yet. I have a patch that tries to, which I haven't been able to test
> because of server issues, but I'll be doing that tomorrow. See the description
> of this CL.
> 
> You can actually see that code (compiled, but never run) up in Patch Set 2 in
> this issue.

I should read change descriptions carefully next time :)

[Pam (message me for reviews), 2013-06-21 09:21:06]

TBR=sail for profiles, kalman for extensions

[commit-bot: I haz the power, 2013-06-21 09:21:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pam@chromium.org/17320005/52002

[commit-bot: I haz the power, 2013-06-21 09:21:52]

Can't process patch for file
chrome/browser/resources/options/managed_user_create_confirm.png.
Binary file support is temporarilly disabled due to a bug. Please commit blindly
the binary files first then commit the source change as a separate CL. Sorry for
the annoyance.

[commit-bot: I haz the power, 2013-06-21 09:49:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pam@chromium.org/17320005/92001

[commit-bot: I haz the power, 2013-06-21 10:04:32]

Retried try job too often on mac for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[Pam (message me for reviews), 2013-06-21 10:13:13]

Sigh... image, *then* code.

[commit-bot: I haz the power, 2013-06-21 10:17:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pam@chromium.org/17320005/92001

[commit-bot: I haz the power, 2013-06-21 10:38:36]

Failed to trigger a try job on chromium_presubmit
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2013-06-21 10:38:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pam@chromium.org/17320005/94005

[commit-bot: I haz the power, 2013-06-21 10:39:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pam@chromium.org/17320005/94005

[commit-bot: I haz the power, 2013-06-21 13:40:05]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[Pam (message me for reviews), 2013-06-21 13:49:41]

Added the two missing files, reviewed by Sergiu in
https://codereview.chromium.org/17552003/

[commit-bot: I haz the power, 2013-06-21 13:49:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pam@chromium.org/17320005/127005

[commit-bot: I haz the power, 2013-06-21 16:13:41]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-06-21 16:20:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pam@chromium.org/17320005/127005

[commit-bot: I haz the power, 2013-06-21 19:06:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pam@chromium.org/17320005/133001

[commit-bot: I haz the power, 2013-06-21 19:27:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pam@chromium.org/17320005/138002

[commit-bot: I haz the power, 2013-06-21 22:46:15]

Change committed as 207943