Issue 1731913002: Move InstanceID field trial check to extension-specific code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1731913002: Move InstanceID field trial check to extension-specific code (Closed)

Created:
4 years, 10 months ago by johnme

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, zea+watch_chromium.org, extensions-reviews_chromium.org, Peter Beverloo

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move InstanceID field trial check to extension-specific code This will allow other parts of Chrome to depend on the InstanceID API. SUPERSEDED BY https://codereview.chromium.org/1736433002 BUG=589461

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -12 lines)			Patch
	M	chrome/browser/extensions/api/instance_id/instance_id_api.cc	View		3 chunks	+10 lines, -1 line	0 comments	Download
	M	components/gcm_driver/instance_id/instance_id_driver.cc	View		1 chunk	+1 line, -11 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

johnme

4 years, 10 months ago (2016-02-24 13:35:59 UTC) #1

Description was changed from

==========
Move InstanceID field trial check to extension-specific code

This will allow other parts of Chrome to depend on the InstanceID API.

BUG=589461
==========

to

==========
Move InstanceID field trial check to extension-specific code

This will allow other parts of Chrome to depend on the InstanceID API.

SUPERSEDED BY https://codereview.chromium.org/1736433002

BUG=589461
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages