Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1736433002: Remove InstanceID field trial, since it is always enabled (Closed)

Created:
4 years, 10 months ago by johnme
Modified:
4 years, 9 months ago
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove InstanceID field trial, since it is always enabled This will allow other parts of Chrome to depend on the InstanceID API. BUG=477084, 589461

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -26 lines) Patch
M components/gcm_driver/instance_id/instance_id_driver.cc View 1 chunk +1 line, -11 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 chunk +0 lines, -5 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 chunk +0 lines, -5 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
johnme
zea@chromium.org: Please review changes in components/gcm_driver/. Also, is there some other kill switch we should ...
4 years, 10 months ago (2016-02-24 13:34:49 UTC) #2
Nicolas Zea
+Jian to review, since he added that field trial.
4 years, 10 months ago (2016-02-24 19:50:43 UTC) #4
jianli
This indeed is used as a temporary kill switch solution, required by the launch. We ...
4 years, 10 months ago (2016-02-24 20:11:06 UTC) #5
johnme
On 2016/02/24 20:11:06, jianli wrote: > This indeed is used as a temporary kill switch ...
4 years, 10 months ago (2016-02-25 12:32:09 UTC) #6
jianli
On 2016/02/25 12:32:09, johnme wrote: > On 2016/02/24 20:11:06, jianli wrote: > > This indeed ...
4 years, 9 months ago (2016-02-29 22:43:53 UTC) #7
johnme
4 years, 9 months ago (2016-03-08 13:30:42 UTC) #9
Message was sent while issue was closed.
On 2016/02/29 22:43:53, jianli wrote:
> On 2016/02/25 12:32:09, johnme wrote:
> > Is the kill switch meant to apply to all uses of InstanceID, or just for the
> > extensions API? I'm about to move Web Push over to InstanceID - does it make
> > sense for us to share this kill switch?
> 
> Yes, it applies to all uses. This will only be deployed when something goes
> terribly wrong that would affect all the uses of InstanceID. So I think we
> should keep as it is. You can add a kill switch specially for web push if you
> feel it is needed.

Sounds reasonable to share it for now, thanks. Abandoning this CL.

Powered by Google App Engine
This is Rietveld 408576698