src/heap/heap.cc - Issue 1731883003: Encode interpreter::SourcePositionTable as variable-length ints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 1731883003: Encode interpreter::SourcePositionTable as variable-length ints. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Really fix leak. SourcePositionTableBuilder is member of a zone-allocated object. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index bfe4f1e3fff9fea755ba41397c10ae8f52300441..767a0f0edd2362841b0705930086ffce6df15424 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -3036,7 +3036,7 @@ AllocationResult Heap::AllocateBytecodeArray(int length,

instance->set_interrupt_budget(interpreter::Interpreter::InterruptBudget());

instance->set_constant_pool(constant_pool);

instance->set_handler_table(empty_fixed_array());

- instance->set_source_position_table(empty_fixed_array());

+ instance->set_source_position_table(empty_byte_array());

CopyBytes(instance->GetFirstBytecodeAddress(), raw_bytecodes, length);

return result;

« no previous file with comments | « src/debug/debug.cc ('k') | src/interpreter/bytecode-array-builder.cc » ('j') | no next file with comments »