src/debug/debug.cc - Issue 1731883003: Encode interpreter::SourcePositionTable as variable-length ints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/debug.cc

Issue 1731883003: Encode interpreter::SourcePositionTable as variable-length ints. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Really fix leak. SourcePositionTableBuilder is member of a zone-allocated object. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug/debug.cc

diff --git a/src/debug/debug.cc b/src/debug/debug.cc

index 93c914c3f8db222ad54144a285caebc476d99c9b..42192b0b5340bebf36e94fadd38b1862c2241831 100644

--- a/src/debug/debug.cc

+++ b/src/debug/debug.cc

@@ -171,8 +171,9 @@ BreakLocation BreakLocation::CodeIterator::GetBreakLocation() {

BreakLocation::BytecodeArrayIterator::BytecodeArrayIterator(

Handle<DebugInfo> debug_info, BreakLocatorType type)

: Iterator(debug_info),

- source_position_iterator_(

- debug_info->abstract_code()->GetBytecodeArray()),

+ source_position_iterator_(debug_info->abstract_code()

+ ->GetBytecodeArray()

+ ->source_position_table()),

break_locator_type_(type),

start_position_(debug_info->shared()->start_position()) {

if (!Done()) Next();

« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »