Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 173172: Breakpads missing from browser process (Closed)

Created:
11 years, 4 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
jeremy
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Breakpads missing from browser process. GoogleUpdateSettings::GetCollectStatsConsent uses the Chrome path provider, so if the Breakpad glue is going to decide whether to enable Breakpad based on that function, it can't call it until after the Chrome path provider has been added to the path service. TBR=jeremy BUG=19913 TEST=Does Breakpad work in the browser process? If stats reporting is enabled, in an official release Google Chrome build, you'd better not see this: [mmdd/hhmmss:WARNING:.../chrome/app/breakpad_mac.mm(57)] Breakpad disabled Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23929

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M chrome/app/chrome_dll_main.cc View 2 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
11 years, 4 months ago (2009-08-21 01:16:49 UTC) #1
jeremy
11 years, 4 months ago (2009-08-21 15:58:17 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698