Breakpads missing from browser process

chrome/app/chrome_dll_main.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(port): the ifdefs in here are a first step towards trying to determine
 // the correct abstraction for all the OS functionality required at this
 // stage of process initialization. It should not be taken as a final
 // abstraction.
 
 #include "build/build_config.h"
@@ skipping 316 matching lines @@
 #endif
 #endif
 
   // Initialize the command line.
 #if defined(OS_WIN)
   CommandLine::Init(0, NULL);
 #else
   CommandLine::Init(argc, argv);
 #endif
 
-#if defined(OS_MACOSX)
-  // TODO(mark): Right now, InitCrashReporter() needs to be called after
-  // CommandLine::Init().  Ideally, Breakpad initialization could occur
-  // sooner, preferably even before the framework dylib is even loaded, to
-  // catch potential early early crashes.
-  InitCrashReporter();
-
-  // If Breakpad is not present, turn off OS crash dumps to avoid having
-  // to wait eons for Apple's Crash Reporter to generate dumps for builds
-  // where debugging symbols are present.
-  if (IsCrashReporterDisabled())
-    DebugUtil::DisableOSCrashDumps();
-  else
-    InitCrashProcessInfo();
-#endif  // OS_MACOSX
-
   const CommandLine& parsed_command_line = *CommandLine::ForCurrentProcess();
 
 #if defined(OS_WIN)
   // Must do this before any other usage of command line!
   if (HasDeprecatedArguments(parsed_command_line.command_line_string()))
     return 1;
 #endif
 
 #if defined(OS_LINUX)
   // Show the man page on --help or -h.
@@ skipping 54 matching lines @@
     if (!DebugUtil::BeingDebugged())
       signal(SIGINT, SIG_IGN);
 #endif
   }
   SetupCRT(parsed_command_line);
 
   // Initialize the Chrome path provider.
   app::RegisterPathProvider();
   chrome::RegisterPathProvider();
 
+#if defined(OS_MACOSX)
+  // TODO(mark): Right now, InitCrashReporter() needs to be called after
+  // CommandLine::Init() and chrome::RegisterPathProvider().  Ideally, Breakpad
+  // initialization could occur sooner, preferably even before the framework
+  // dylib is even loaded, to catch potential early crashes.
+  InitCrashReporter();
+
+  // If Breakpad is not present, turn off OS crash dumps to avoid having
+  // to wait eons for Apple's Crash Reporter to generate dumps for builds
+  // where debugging symbols are present.
+  if (IsCrashReporterDisabled())
+    DebugUtil::DisableOSCrashDumps();
+  else
+    InitCrashProcessInfo();
+#endif  // OS_MACOSX
+
   // Initialize the Stats Counters table.  With this initialized,
   // the StatsViewer can be utilized to read counters outside of
   // Chrome.  These lines can be commented out to effectively turn
   // counters 'off'.  The table is created and exists for the life
   // of the process.  It is not cleaned up.
   // TODO(port): we probably need to shut this down correctly to avoid
   // leaking shared memory regions on posix platforms.
   if (parsed_command_line.HasSwitch(switches::kEnableStatsTable)) {
     std::string statsfile =
         StringPrintf("%s-%d", chrome::kStatsFilename, browser_pid);
@@ skipping 135 matching lines @@
 
   logging::CleanupChromeLogging();
 
 #if defined(OS_MACOSX) && defined(GOOGLE_CHROME_BUILD)
   // TODO(mark): See the TODO(mark) above at InitCrashReporter.
   DestructCrashReporter();
 #endif  // OS_MACOSX && GOOGLE_CHROME_BUILD
 
   return rv;
 }