content/browser/renderer_host/render_widget_host_view_android.cc - Issue 1731673002: Add tab reparenting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 1731673002: Add tab reparenting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added visible for testing to externalPrerenderHandler method Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index d0f4d0ede65b8494dfd14409297230e18b7f5514..109d9163ad8750a8454fbe3a09adf99abd256633 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -1759,12 +1759,10 @@ void RenderWidgetHostViewAndroid::SetContentViewCore(

selection_controller_.reset();

ReleaseLocksOnSurface();

resize = true;

- if (content_view_core_) {

- if (!content_view_core)

- content_view_core_->RemoveObserver(this);

- else

- content_view_core->AddObserver(this);

- }

+ if (content_view_core_)

+ content_view_core_->RemoveObserver(this);

+ if (content_view_core)

+ content_view_core->AddObserver(this);

}

content_view_core_ = content_view_core;