chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java - Issue 1731673002: Add tab reparenting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java

Issue 1731673002: Add tab reparenting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added visible for testing to externalPrerenderHandler method Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/tabmodel/AsyncTabParamsManager.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/tabmodel/OffTheRecordTabModel.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java

index feb93f1d4ad81f4c1da60f4cbbdacdb38a969dd5..59cb53f8000815a0d4b838c734687f8da5c6c74c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java

@@ -172,6 +172,10 @@ public class SingleTabModel implements TabModel {

}

@Override

+ public void removeTab(Tab tab) {

Ted C 2016/02/26 18:46:29 I would add an assert false to each of the empty o

Yusuf 2016/02/26 19:39:52 Done.

+ }

+ @Override

public void addObserver(TabModelObserver observer) {

mObservers.addObserver(observer);

}