Issue 173166: Implement granular cross-origin XHR for extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173166: Implement granular cross-origin XHR for extensions. (Closed)

Created:
11 years, 4 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Implement granular cross-origin XHR for extensions. I left the temporary hack that allows all origins until we are ready to break everything all at once. Also, I still need to devise some way to test this. BUG=12129

Patch Set 1 #

Patch Set 2 : some cleanup #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -18 lines)			Patch
M	chrome/browser/extensions/extension_function_dispatcher.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/common/render_messages.h	View		2 chunks	+20 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	chrome/renderer/extensions/extension_process_bindings.h	View	1	2 chunks	+10 lines, -3 lines	0 comments	Download
M	chrome/renderer/extensions/extension_process_bindings.cc	View		3 chunks	+18 lines, -2 lines	0 comments	Download
M	chrome/renderer/render_thread.h	View		2 chunks	+6 lines, -3 lines	1 comment	Download
M	chrome/renderer/render_thread.cc	View		2 chunks	+11 lines, -4 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

11 years, 4 months ago (2009-08-21 00:30:06 UTC) #2

weee! lgtm

http://codereview.chromium.org/173166/diff/13/20
File chrome/renderer/render_thread.h (right):

http://codereview.chromium.org/173166/diff/13/20#newcode131
Line 131: const std::vector<std::string>& permissions);
80 chars

Expand Messages | Collapse Messages