Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7056)

Unified Diff: chrome/renderer/render_view.cc

Issue 173166: Implement granular cross-origin XHR for extensions. (Closed)
Patch Set: some cleanup Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/renderer/render_thread.h ('K') | « chrome/renderer/render_thread.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/render_view.cc
diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc
index 5bd7c24f7e34522d070e9ae13d6a6cbdb68a00f5..ba3d8d3c415e14a1bbaafd01d7fb2131ad029e65 100644
--- a/chrome/renderer/render_view.cc
+++ b/chrome/renderer/render_view.cc
@@ -1566,10 +1566,7 @@ void RenderView::WindowObjectCleared(WebFrame* frame) {
}
void RenderView::DocumentElementAvailable(WebFrame* frame) {
- // TODO(mpcomplete): remove this before Chrome extensions ship.
- // HACK. This is a temporary workaround to allow cross-origin XHR for Chrome
- // extensions. It grants full access to every origin, when we really want
- // to be able to restrict them more specifically.
+ // TODO(aa): Remove this before dev release.
GURL url = frame->url();
if (url.SchemeIs(chrome::kExtensionScheme))
frame->grantUniversalAccess();
« chrome/renderer/render_thread.h ('K') | « chrome/renderer/render_thread.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698