Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1731593002: Fix hotword module constantly restarting on Pixel 2. (Closed)

Created:
4 years, 10 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

Fix hotword module constantly restarting on Pixel 2. The "googHotword" audio constraint used on the Pixel 2 is an optional constraint. BUG=583720 TEST=Manually tested "Ok Google" on Pixel 2. R=tommi@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/1a1c81ec936c85443994a2e19859acede59c6bb0

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M content/renderer/media/user_media_client_impl.cc View 2 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Matt Giuca
I think it's fine to land this manually into the branch but we need to ...
4 years, 10 months ago (2016-02-24 02:23:24 UTC) #2
Anand Mistry (off Chromium)
tommi@chromium.org: I'm still waiting for advice on submitting this to the M49 branch, but as ...
4 years, 10 months ago (2016-02-25 22:46:35 UTC) #5
tommi (sloooow) - chröme
lgtm
4 years, 10 months ago (2016-02-26 12:23:27 UTC) #6
Anand Mistry (off Chromium)
4 years, 9 months ago (2016-03-03 06:51:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1a1c81ec936c85443994a2e19859acede59c6bb0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698