Optimizing noSuchMethod invocation with no arguments.

Optimizing noSuchMethod invocation with no arguments.

On each call that triggers a noSuchMethod invocation we 
attach a custom dispatch function that allocates the 
invocation object and invokes noSuchMethod. This dispatcher
is compiled and optimized like a normal Dart function.

Similar to method-extractors, these implicit dispatchers
do not show up as normal functions.

As a first step this CL only handles invocations of getters
and methods with no like o.foo or o.foo().  This CL gives
a >25x speedup of such noSuchMethod invocations. Calls with
multiple arguments still go through the slow path.

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24266

[srdjan, 2013-06-19 18:10:56]

Some quick initial comments.
What about stacktrace? Is the artificial function hidden?

https://codereview.chromium.org/17315008/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/17315008/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1195:
Function::New(String::Handle(Symbols::New(target_name)),
indent 4 spaces

https://codereview.chromium.org/17315008/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1257: if (desc.Count() == 1 &&
desc.PositionalCount() == 1) {
Add parentheses.
Add TODO to handle other cases.

https://codereview.chromium.org/17315008/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1274: DartEntry::InvokeFunction(target_function,
args, args_descriptor);
Why not:
  result =DartEntry::InvokeFunction(targ..
} else {
   result = DartEntry::InvokeNoSuchMethod(receiver, ...
}
CheckResultError(result);
arguments.SetReturn(result);

[Florian Schneider, 2013-06-20 09:23:33]

Done. Marked the dispatcher functions invisible to hide it in stack traces.

https://codereview.chromium.org/17315008/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/17315008/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1195:
Function::New(String::Handle(Symbols::New(target_name)),
On 2013/06/19 18:10:56, srdjan wrote:
> indent 4 spaces

Done.

https://codereview.chromium.org/17315008/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1257: if (desc.Count() == 1 &&
desc.PositionalCount() == 1) {
On 2013/06/19 18:10:56, srdjan wrote:
> Add parentheses.
> Add TODO to handle other cases.

Done.

https://codereview.chromium.org/17315008/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1274: DartEntry::InvokeFunction(target_function,
args, args_descriptor);
On 2013/06/19 18:10:56, srdjan wrote:
> Why not:
>   result =DartEntry::InvokeFunction(targ..
> } else {
>    result = DartEntry::InvokeNoSuchMethod(receiver, ...
> }
> CheckResultError(result);
> arguments.SetReturn(result);

Done.

[srdjan, 2013-06-20 16:34:16]

lgtm

https://codereview.chromium.org/17315008/diff/13001/runtime/vm/flow_graph_opt...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/17315008/diff/13001/runtime/vm/flow_graph_opt...
runtime/vm/flow_graph_optimizer.cc:1507: return false;
Optional: merge the two conditions into one else if.

https://codereview.chromium.org/17315008/diff/13001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/17315008/diff/13001/runtime/vm/parser.cc#newc...
runtime/vm/parser.cc:1143: 
ASSERT that func kind is RawFunction::kNoSuchMethodDispatcher.

[Ivan Posva, 2013-06-20 17:21:08]

https://codereview.chromium.org/17315008/diff/13001/runtime/vm/resolver.cc
File runtime/vm/resolver.cc (right):

https://codereview.chromium.org/17315008/diff/13001/runtime/vm/resolver.cc#ne...
runtime/vm/resolver.cc:141: if (!function.IsNull() &&
!function.IsNoSuchMethodDispatcher()) {
Please add a language test which verifies this.

[Florian Schneider, 2013-06-21 06:46:26]

https://codereview.chromium.org/17315008/diff/13001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/17315008/diff/13001/runtime/vm/parser.cc#newc...
runtime/vm/parser.cc:1143: 
On 2013/06/20 16:34:17, srdjan wrote:
> ASSERT that func kind is RawFunction::kNoSuchMethodDispatcher.

Done.

https://codereview.chromium.org/17315008/diff/13001/runtime/vm/resolver.cc
File runtime/vm/resolver.cc (right):

https://codereview.chromium.org/17315008/diff/13001/runtime/vm/resolver.cc#ne...
runtime/vm/resolver.cc:141: if (!function.IsNull() &&
!function.IsNoSuchMethodDispatcher()) {
On 2013/06/20 17:21:08, Ivan Posva wrote:
> Please add a language test which verifies this.

Done. Added test, but it is also covered by tests/language/interceptor_test.

[Florian Schneider, 2013-06-21 07:32:06]

Committed patchset #3 manually as r24266 (presubmit successful).

[srdjan, 2013-06-24 16:23:15]

LGTM