Optimizing noSuchMethod invocation with no arguments.

runtime/vm/parser.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/parser.h"
 
 #include "lib/invocation_mirror.h"
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
@@ skipping 784 matching lines @@
     case RawFunction::kImplicitSetter:
       ASSERT(!func.is_static());
       node_sequence = parser.ParseInstanceSetter(func);
       break;
     case RawFunction::kConstImplicitGetter:
       node_sequence = parser.ParseStaticConstGetter(func);
       break;
     case RawFunction::kMethodExtractor:
       node_sequence = parser.ParseMethodExtractor(func);
       break;
+    case RawFunction::kNoSuchMethodDispatcher:
+      node_sequence = parser.ParseNoSuchMethodDispatcher(func);
+      break;
     default:
       UNREACHABLE();
   }
 
   if (!HasReturnNode(node_sequence)) {
     // Add implicit return node.
     node_sequence->Add(new ReturnNode(func.end_token_pos()));
   }
   if (parsed_function->has_expression_temp_var()) {
     node_sequence->scope()->AddVariable(parsed_function->expression_temp_var());
@@ skipping 312 matching lines @@
       Function::ZoneHandle(func.extracted_method_closure()),
       load_receiver,
       NULL);
 
   ReturnNode* return_node = new ReturnNode(ident_pos, closure);
   current_block_->statements->Add(return_node);
   return CloseBlock();
 }
 
 
+SequenceNode* Parser::ParseNoSuchMethodDispatcher(const Function& func) {
+  TRACE_PARSER("ParseNoSuchMethodDispatcher");
+  ParamList params;
+

[srdjan, 2013/06/20 16:34:17]

ASSERT that func kind is RawFunction::kNoSuchMethodDispatcher.

[Florian Schneider, 2013/06/21 06:46:26]

Done.

+  intptr_t token_pos = func.token_pos();
+  ASSERT(func.token_pos() == 0);
+  ASSERT(current_class().raw() == func.Owner());
+  params.AddReceiver(ReceiverType(token_pos));
+  ASSERT(func.num_fixed_parameters() == 1);  // Receiver.
+  ASSERT(!func.HasOptionalParameters());
+
+  // Build local scope for function and populate with the formal parameters.
+  OpenFunctionBlock(func);
+  LocalScope* scope = current_block_->scope;
+  AddFormalParamsToScope(&params, scope);
+
+  // Receiver is local 0.
+  LocalVariable* receiver = scope->VariableAt(0);
+  LoadLocalNode* load_receiver = new LoadLocalNode(token_pos, receiver);
+
+  ArgumentListNode* func_args = new ArgumentListNode(token_pos);
+  func_args->Add(load_receiver);
+  const String& func_name = String::ZoneHandle(func.name());
+  ArgumentListNode* arguments = BuildNoSuchMethodArguments(token_pos,
+                                                           func_name,
+                                                           *func_args);
+  const Function& no_such_method = Function::ZoneHandle(
+        Resolver::ResolveDynamicAnyArgs(Class::Handle(func.Owner()),
+                                        Symbols::NoSuchMethod()));
+  StaticCallNode* call =
+      new StaticCallNode(token_pos, no_such_method, arguments);
+
+
+  ReturnNode* return_node = new ReturnNode(token_pos, call);
+  current_block_->statements->Add(return_node);
+  return CloseBlock();
+}
+
+
 void Parser::SkipBlock() {
   ASSERT(CurrentToken() == Token::kLBRACE);
   GrowableArray<Token::Kind> token_stack(8);
   const intptr_t block_start_pos = TokenPos();
   bool is_match = true;
   bool unexpected_token_found = false;
   Token::Kind token;
   intptr_t token_pos;
   do {
     token = CurrentToken();
@@ skipping 8958 matching lines @@
 void Parser::SkipQualIdent() {
   ASSERT(IsIdentifier());
   ConsumeToken();
   if (CurrentToken() == Token::kPERIOD) {
     ConsumeToken();  // Consume the kPERIOD token.
     ExpectIdentifier("identifier expected after '.'");
   }
 }
 
 }  // namespace dart