Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1731453002: Reduce histogram creation time by avoiding import of those just created. (Closed)

Created:
4 years, 10 months ago by bcwhite
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce histogram creation time by avoiding import of those just created. Attempting to import histograms in the persistent memory segment is necessary because it could be shared and thus have other processes creating objects within it. However, there's no need to import those objects that this process created. The simple method remembering the "reference" of the last histogram created in the allocator catches almost all cases and reduces histogram creation time by 40%. BUG=546019 Done as part of https://codereview.chromium.org/1738063002/

Patch Set 1 #

Patch Set 2 : clear last-histogram when releasing allocator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -8 lines) Patch
M base/metrics/histogram_persistence.cc View 1 5 chunks +31 lines, -5 lines 0 comments Download
M base/metrics/histogram_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
bcwhite
4 years, 9 months ago (2016-03-16 02:51:59 UTC) #1 
Description was changed from

==========
Reduce histogram creation time by avoiding import of those just created.

Attempting to import histograms in the persistent memory
segment is necessary because it could be shared and thus
have other processes creating objects within it. However,
there's no need to import those objects that this process
created.

The simple method remembering the "reference" of the last
histogram created in the allocator catches almost all
cases and reduces histogram creation time by 40%.

BUG=546019
==========

to

==========
Reduce histogram creation time by avoiding import of those just created.

Attempting to import histograms in the persistent memory
segment is necessary because it could be shared and thus
have other processes creating objects within it. However,
there's no need to import those objects that this process
created.

The simple method remembering the "reference" of the last
histogram created in the allocator catches almost all
cases and reduces histogram creation time by 40%.

BUG=546019

Done as part of https://codereview.chromium.org/1738063002/
==========

Powered by Google App Engine
This is Rietveld 408576698