Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1924)

Unified Diff: Tools/GardeningServer/scripts/checkout_unittests.js

Issue 173133003: Convert garden-o-matic guts over to promises where appropriate (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: update to ToT Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/scripts/checkout.js ('k') | Tools/GardeningServer/scripts/controllers.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/scripts/checkout_unittests.js
diff --git a/Tools/GardeningServer/scripts/checkout_unittests.js b/Tools/GardeningServer/scripts/checkout_unittests.js
index 833e0d5396fcb88843ab87363fc3798d9bf6c910..c557ce8e2399282d4333a3335451140c408603a6 100644
--- a/Tools/GardeningServer/scripts/checkout_unittests.js
+++ b/Tools/GardeningServer/scripts/checkout_unittests.js
@@ -97,14 +97,14 @@ asyncTest("rebaseline", 3, function() {
'builderName': 'Webkit Win7',
'testName': 'fast/test.html',
'failureTypeList': ['IMAGE+TEXT'],
- }], function() {
- ok(true);
- }, function(failureInfo) {
+ }], function(failureInfo) {
equals(failureInfo.testName, kExpectedTestNameProgressStack.pop());
}, function() {
- ok(false, 'Checkout should be available.');
- }, function() {
ok(false, 'There are no debug bots in the list');
+ }).catch().then(function() {
+ ok(true);
+ }, function() {
+ ok(false, 'Checkout should be available.');
});
}).then(function() {
@@ -138,14 +138,14 @@ asyncTest("rebaseline-debug-bot", 3, function() {
'builderName': 'WebKit Linux (dbg)',
'testName': 'another/test.svg',
'failureTypeList': ['IMAGE'],
- }], function() {
- ok(true);
- }, function(failureInfo) {
+ }], function(failureInfo) {
ok(false);
- }, function() {
- ok(false, 'Checkout should be available.');
}, function(failureInfo) {
ok(true);
+ }).then(function() {
+ ok(true);
+ }, function() {
+ ok(false);
});
}).then(start);
});
« no previous file with comments | « Tools/GardeningServer/scripts/checkout.js ('k') | Tools/GardeningServer/scripts/controllers.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698