Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: src/js/v8natives.js

Issue 1731063007: Remove the global Strength enum class completely. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_strong-remove-literals
Patch Set: Remove more cruft. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/js/macros.py ('k') | src/json-parser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/v8natives.js
diff --git a/src/js/v8natives.js b/src/js/v8natives.js
index f99564e8410bc6480be4fa2ff458463ea644c269..2dda1a3b27e879d5aa75b34f13110811d9b3d692 100644
--- a/src/js/v8natives.js
+++ b/src/js/v8natives.js
@@ -573,11 +573,9 @@ function DefineObjectProperty(obj, p, desc, should_throw) {
if (IsDataDescriptor(current) && IsDataDescriptor(desc)) {
var currentIsWritable = current.isWritable();
if (currentIsWritable != desc.isWritable()) {
- if (!currentIsWritable || IS_STRONG(obj)) {
+ if (!currentIsWritable) {
if (should_throw) {
- throw currentIsWritable
- ? MakeTypeError(kStrongRedefineDisallowed, obj, p)
- : MakeTypeError(kRedefineDisallowed, p);
+ throw MakeTypeError(kRedefineDisallowed, p);
} else {
return false;
}
« no previous file with comments | « src/js/macros.py ('k') | src/json-parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698