Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1730893003: Remove include only barcode.h and IWYU. (Closed)

Created:
4 years, 10 months ago by dsinclair
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -142 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M xfa.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_BarCode.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_Binarizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_BinaryBitmap.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_Dimension.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_Library.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_LuminanceSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_Reader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_ResultPoint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_TwoDimWriter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_UtilCodingConvert.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_UtilRSS.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_Utils.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_Writer.cpp View 1 chunk +1 line, -1 line 0 comments Download
D xfa/src/fxbarcode/barcode.h View 1 chunk +0 lines, -15 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonBitArray.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonBitArray.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonBitMatrix.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonBitMatrix.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonBitSource.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonBitSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonByteArray.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonByteArray.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonByteMatrix.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonByteMatrix.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonCharacterSetECI.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonCharacterSetECI.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonDecoderResult.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonDecoderResult.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonECI.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonECI.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonPerspectiveTransform.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonPerspectiveTransform.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/common/BC_GlobalHistogramBinarizer.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/common/BC_WhiteRectangleDetector.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_WhiteRectangleDetector.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomon.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomon.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonDecoder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_ASCIIEncoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_Base256Encoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_C40Encoder.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixBitMatrixParser.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixBitMatrixParser.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixDataBlock.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixDataBlock.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixDecodedBitStreamParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixDecoder.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixReader.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixSymbolInfo144.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixVersion.h View 3 chunks +5 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixVersion.cpp View 1 1 chunk +5 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixWriter.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DefaultPlacement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DefaultPlacement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_EdifactEncoder.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_Encoder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_Encoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_EncoderContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_ErrorCorrection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_HighLevelEncoder.cpp View 3 chunks +4 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_SymbolInfo.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_SymbolInfo.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_SymbolShapeHint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_TextEncoder.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_X12Encoder.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OneDReader.h View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OneDReader.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OneDimReader.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OneDimWriter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCodaBarWriter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCode128Reader.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCode128Writer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCode39Reader.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCode39Writer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedEAN13Reader.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedEAN13Writer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedEAN8Reader.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedEAN8Writer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedUPCAReader.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedUPCAWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417BarcodeMatrix.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417BarcodeMatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417BarcodeMetadata.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417BarcodeMetadata.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417BarcodeRow.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417BarcodeRow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417BarcodeValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417BarcodeValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417BoundingBox.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417BoundingBox.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417Codeword.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417Codeword.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417CodewordDecoder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417CodewordDecoder.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417Common.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417Common.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417Compaction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417DecodedBitStreamParser.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417DetectionResult.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417DetectionResultColumn.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417DetectionResultRowIndicatorColumn.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417Detector.cpp View 4 chunks +7 lines, -4 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417DetectorResult.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417DetectorResult.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417Dimensions.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417Dimensions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417ECErrorCorrection.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417ECModulusGF.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417ECModulusPoly.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417ErrorCorrection.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417ErrorCorrection.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417HighLevelEncoder.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417Reader.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417ResultMetadata.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417ResultMetadata.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417Writer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_FinderPatternInfo.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_FinderPatternInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRAlignmentPattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRAlignmentPatternFinder.h View 1 chunk +4 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRAlignmentPatternFinder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRBitMatrixParser.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRBitMatrixParser.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCodeReader.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCodeWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoder.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderBitVector.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderBitVector.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderBlockPair.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderDecoder.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderECB.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderECB.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderECBlocks.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderECBlocks.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderEncoder.cpp View 3 chunks +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderErrorCorrectionLevel.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderErrorCorrectionLevel.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderFormatInformation.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderMaskUtil.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderMatrixUtil.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderMode.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderMode.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderVersion.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderVersion.cpp View 3 chunks +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDataBlock.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDataMask.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDataMask.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDecodedBitStreamParser.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDetector.cpp View 2 chunks +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDetectorResult.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDetectorResult.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRFinderPattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRFinderPatternFinder.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRGridSampler.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/utils.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dsinclair
PTAL.
4 years, 10 months ago (2016-02-24 20:08:58 UTC) #3
Lei Zhang
https://codereview.chromium.org/1730893003/diff/20001/xfa/src/fxbarcode/qrcode/BC_QRCoderMode.h File xfa/src/fxbarcode/qrcode/BC_QRCoderMode.h (right): https://codereview.chromium.org/1730893003/diff/20001/xfa/src/fxbarcode/qrcode/BC_QRCoderMode.h#newcode10 xfa/src/fxbarcode/qrcode/BC_QRCoderMode.h:10: #include <cstdint> stdint.h, unless you want std::uint32_t ditto elsewhere.
4 years, 10 months ago (2016-02-24 20:28:24 UTC) #4
dsinclair
https://codereview.chromium.org/1730893003/diff/20001/xfa/src/fxbarcode/qrcode/BC_QRCoderMode.h File xfa/src/fxbarcode/qrcode/BC_QRCoderMode.h (right): https://codereview.chromium.org/1730893003/diff/20001/xfa/src/fxbarcode/qrcode/BC_QRCoderMode.h#newcode10 xfa/src/fxbarcode/qrcode/BC_QRCoderMode.h:10: #include <cstdint> On 2016/02/24 20:28:24, Lei Zhang wrote: > ...
4 years, 10 months ago (2016-02-24 20:32:35 UTC) #5
Lei Zhang
lgtm https://codereview.chromium.org/1730893003/diff/20001/xfa/src/fxbarcode/pdf417/BC_PDF417Detector.cpp File xfa/src/fxbarcode/pdf417/BC_PDF417Detector.cpp (right): https://codereview.chromium.org/1730893003/diff/20001/xfa/src/fxbarcode/pdf417/BC_PDF417Detector.cpp#newcode31 xfa/src/fxbarcode/pdf417/BC_PDF417Detector.cpp:31: #define INTEGER_MAX 2147483647 Delete and use INT_MAX or ...
4 years, 10 months ago (2016-02-24 20:38:00 UTC) #6
dsinclair
https://codereview.chromium.org/1730893003/diff/20001/xfa/src/fxbarcode/pdf417/BC_PDF417Detector.cpp File xfa/src/fxbarcode/pdf417/BC_PDF417Detector.cpp (right): https://codereview.chromium.org/1730893003/diff/20001/xfa/src/fxbarcode/pdf417/BC_PDF417Detector.cpp#newcode31 xfa/src/fxbarcode/pdf417/BC_PDF417Detector.cpp:31: #define INTEGER_MAX 2147483647 On 2016/02/24 20:37:59, Lei Zhang wrote: ...
4 years, 10 months ago (2016-02-24 20:39:21 UTC) #7
dsinclair
4 years, 10 months ago (2016-02-24 20:40:01 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
320510d590f4e8df3a4725a87b54446c7009e57e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698