Chromium Code Reviews Chromium Code Reviews
Issue
1730893002:
Revert of Remove DialogDelegate::OnClosed() which is redundant with (Closed)
DescriptionRevert of Remove DialogDelegate::OnClosed() which is redundant with (patchset #9 id:160001 of https://codereview.chromium.org/1686433002/ )
Reason for revert:
Failure Builder: Linux Chromium OS ASan LSan Tests (1)
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/9985/steps/browser_tests%20on%20Ubuntu-12.04/logs/DeviceLocalAccountTest.AutoLoginWithRecommendedLocales
==12959==ERROR: AddressSanitizer: heap-use-after-free on address 0x60e000047640 at pc 0x0000008c9c62 bp 0x7ffc51d4ad70 sp 0x7ffc51d4a530
WRITE of size 16 at 0x60e000047640 thread T0 (browser_tests)
#0 0x8c9c61 in __asan_memset (/tmp/runKDXLlt/out/Release/browser_tests+0x8c9c61)
#1 0x7cb68dc in ash::LogoutConfirmationController::OnDialogClosed() ash/system/chromeos/session/logout_confirmation_controller.cc:83:11
#2 0x5ce779b in views::Widget::OnNativeWidgetDestroying() ui/views/widget/widget.cc:1088:3
#3 0x5d0a61e in OnWindowDestroying ui/views/widget/native_widget_aura.cc:830:3
#4 0x5d0a61e in non-virtual thunk to views::NativeWidgetAura::OnWindowDestroying(aura::Window*) ui/views/widget/native_widget_aura.cc:828
#5 0xde3a857 in aura::Window::~Window() ui/aura/window.cc:109:5
#6 0xde3c02d in aura::Window::~Window() ui/aura/window.cc:102:19
#7 0x7c41d9c in ash::RootWindowController::CloseChildWindows() ash/root_window_controller.cc:533:7
#8 0x7bc1b5e in ash::WindowTreeHostManager::CloseChildWindows() ash/display/window_tree_host_manager.cc:350:7
#9 0x7c8a720 in ash::Shell::~Shell() ash/shell.cc:767:3
#10 0x7c8dc1d in ash::Shell::~Shell() ash/shell.cc:661:17
#11 0x7c81f98 in ash::Shell::DeleteInstance() ash/shell.cc:210:3
#12 0x6599ab1 in chrome::CloseAsh() chrome/browser/ui/ash/ash_init.cc:104:5
#13 0x1231270c in ChromeBrowserMainParts::PostMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:1850:5
#14 0x56a5a84 in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() chrome/browser/chromeos/chrome_browser_main_chromeos.cc:837:3
#15 0x80b952e in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() content/browser/browser_main_loop.cc:987:5
#16 0x88036cc in content::BrowserMainRunnerImpl::Shutdown() content/browser/browser_main_runner.cc:208:7
#17 0x13830cf5 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:46:3
#18 0x1184b150 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:764:12
#19 0x118482ca in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:15
#20 0x4641e54 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:277:3
#21 0x4404695 in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:255:3
#22 0x2ecfc4b in policy::DeviceLocalAccountTest::SetUp() chrome/browser/chromeos/policy/device_local_account_browsertest.cc:440:5
#23 0x4ff7ed6 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12
#24 0x4ff7ed6 in testing::Test::Run() testing/gtest/src/gtest.cc:2470
#25 0x4ffa837 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:5
#26 0x4ffb62a in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:5
#27 0x5010420 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:11
#28 0x500f84b in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12
#29 0x500f84b in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255
#30 0x45dc506 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:10
#31 0x45dc506 in base::TestSuite::Run() base/test/test_suite.cc:231
#32 0x288fafa in ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/browser_tests_main.cc:14:12
#33 0x118cb72b in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) content/public/test/test_launcher.cc:499:12
#34 0x42caaa2 in LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) chrome/test/base/chrome_test_launcher.cc:128:10
#35 0x288f9fc in main chrome/test/base/browser_tests_main.cc:21:10
#36 0x7f125cc1276c in __libc_start_main /build/eglibc-rrybNj/eglibc-2.15/csu/libc-start.c:226
Original issue's description:
> Remove DialogDelegate::OnClosed() which is redundant with
> WidgetDelegate::WindowClosing().
>
> BUG=585312, 583330
> TBR=avi@chromium.org
>
> Committed: https://crrev.com/6f69f42209045c9d0c8b6bfc44d83ca6eca70a74
> Cr-Commit-Position: refs/heads/master@{#377057}
TBR=msw@chromium.org,vasilii@chromium.org,sky@chromium.org,avi@chromium.org,estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=585312, 583330
Committed: https://crrev.com/52a7aabb6b0065b9895f8b80397b9bc35f4752a7
Cr-Commit-Position: refs/heads/master@{#377151}
Patch Set 1 #Messages
Total messages: 8 (3 generated)
|
