chrome/browser/ui/views/first_run_dialog.h - Issue 1730893002: Revert of Remove DialogDelegate::OnClosed() which is redundant with

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/first_run_dialog.h

Issue 1730893002: Revert of Remove DialogDelegate::OnClosed() which is redundant with (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc ('k') | chrome/browser/ui/views/first_run_dialog.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_VIEWS_FIRST_RUN_DIALOG_H_	5 #ifndef CHROME_BROWSER_UI_VIEWS_FIRST_RUN_DIALOG_H_

6 #define CHROME_BROWSER_UI_VIEWS_FIRST_RUN_DIALOG_H_	6 #define CHROME_BROWSER_UI_VIEWS_FIRST_RUN_DIALOG_H_

7	7

8 #include "base/callback.h"	8 #include "base/callback.h"

9 #include "base/macros.h"	9 #include "base/macros.h"

10 #include "ui/views/controls/link_listener.h"	10 #include "ui/views/controls/link_listener.h"

(...skipping 15 matching lines...) Expand all Loading...
26	26

27 private:	27 private:

28 explicit FirstRunDialog(Profile* profile);	28 explicit FirstRunDialog(Profile* profile);

29 ~FirstRunDialog() override;	29 ~FirstRunDialog() override;

30	30

31 // This terminates the nested message-loop.	31 // This terminates the nested message-loop.

32 void Done();	32 void Done();

33	33

34 // views::DialogDelegate:	34 // views::DialogDelegate:

35 views::View* CreateExtraView() override;	35 views::View* CreateExtraView() override;

	36 void OnClosed() override;

36 bool Accept() override;	37 bool Accept() override;

37 int GetDialogButtons() const override;	38 int GetDialogButtons() const override;

38	39

39 // views::WidgetDelegate:

40 void WindowClosing() override;

41

42 // views::LinkListener:	40 // views::LinkListener:

43 void LinkClicked(views::Link* source, int event_flags) override;	41 void LinkClicked(views::Link* source, int event_flags) override;

44	42

45 Profile* profile_;	43 Profile* profile_;

46 views::Checkbox* make_default_;	44 views::Checkbox* make_default_;

47 views::Checkbox* report_crashes_;	45 views::Checkbox* report_crashes_;

48 base::Closure quit_runloop_;	46 base::Closure quit_runloop_;

49	47

50 DISALLOW_COPY_AND_ASSIGN(FirstRunDialog);	48 DISALLOW_COPY_AND_ASSIGN(FirstRunDialog);

51 };	49 };

52	50

53 #endif // CHROME_BROWSER_UI_VIEWS_FIRST_RUN_DIALOG_H_	51 #endif // CHROME_BROWSER_UI_VIEWS_FIRST_RUN_DIALOG_H_

OLD	NEW