Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1730823002: Disable all NEON in BoringSSL if has_broken_neon is set. (Closed)

Created:
4 years, 10 months ago by davidben
Modified:
4 years, 10 months ago
Reviewers:
agl
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable all NEON in BoringSSL if has_broken_neon is set. Originally "broken NEON" and "no NEON" were separate states so that only the poly1305 code would disable it. This ended up being set on only one CPU, so rather than have to worry about whether the new NEON ChaCha20 and Poly1305 code still triggers it, disable all BoringSSL NEON code. This means we can simplify BoringSSL's NEON state slightly. BUG=589200 Committed: https://crrev.com/396d38c7d55e1c039069017afd74488cac9060cd Cr-Commit-Position: refs/heads/master@{#377180}

Patch Set 1 #

Patch Set 2 : might help to land something that actually compiles... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M crypto/openssl_util.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
davidben
4 years, 10 months ago (2016-02-23 22:58:25 UTC) #2
agl
LGTM. Confirmed that FUNCTIONAL is enabled by default.
4 years, 10 months ago (2016-02-23 23:02:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730823002/1
4 years, 10 months ago (2016-02-23 23:16:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/26216) android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, ...
4 years, 10 months ago (2016-02-23 23:23:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730823002/20001
4 years, 10 months ago (2016-02-23 23:24:25 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/149846)
4 years, 10 months ago (2016-02-24 00:29:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730823002/20001
4 years, 10 months ago (2016-02-24 00:40:51 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-24 01:39:44 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 01:41:44 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/396d38c7d55e1c039069017afd74488cac9060cd
Cr-Commit-Position: refs/heads/master@{#377180}

Powered by Google App Engine
This is Rietveld 408576698