Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: crypto/openssl_util.cc

Issue 1730823002: Disable all NEON in BoringSSL if has_broken_neon is set. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: might help to land something that actually compiles... Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: crypto/openssl_util.cc
diff --git a/crypto/openssl_util.cc b/crypto/openssl_util.cc
index 48ec3e2e3936bb3acefb736743c297a8ec78c29b..410cab5a88872ef4e47f11b9d227cec0a180a224 100644
--- a/crypto/openssl_util.cc
+++ b/crypto/openssl_util.cc
@@ -48,13 +48,12 @@ class OpenSSLInitSingleton {
#if defined(OS_ANDROID) && defined(ARCH_CPU_ARMEL)
const bool has_neon =
(android_getCpuFeatures() & ANDROID_CPU_ARM_FEATURE_NEON) != 0;
- // CRYPTO_set_NEON_capable is called before |SSL_library_init| because this
- // stops BoringSSL from probing for NEON support via SIGILL in the case
- // that getauxval isn't present.
- CRYPTO_set_NEON_capable(has_neon);
- // See https://code.google.com/p/chromium/issues/detail?id=341598
base::CPU cpu;
- CRYPTO_set_NEON_functional(!cpu.has_broken_neon());
+ // CRYPTO_set_NEON_capable is called before |SSL_library_init| because this
+ // stops BoringSSL from probing for NEON support via SIGILL in the case that
+ // getauxval isn't present. Also workaround a CPU with broken NEON
+ // support. See https://code.google.com/p/chromium/issues/detail?id=341598
+ CRYPTO_set_NEON_capable(has_neon && !cpu.has_broken_neon());
#endif
SSL_library_init();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698