Disable all NEON in BoringSSL if has_broken_neon is set.

Disable all NEON in BoringSSL if has_broken_neon is set.

Originally "broken NEON" and "no NEON" were separate states so that only the
poly1305 code would disable it. This ended up being set on only one CPU, so
rather than have to worry about whether the new NEON ChaCha20 and Poly1305 code
still triggers it, disable all BoringSSL NEON code.

This means we can simplify BoringSSL's NEON state slightly.

BUG=589200
Committed: https://crrev.com/396d38c7d55e1c039069017afd74488cac9060cd
Cr-Commit-Position: refs/heads/master@{#377180}

[davidben, 2016-02-23 22:58:24]

davidben@chromium.org changed reviewers:
+ agl@chromium.org

[agl, 2016-02-23 23:02:24]

LGTM.

Confirmed that FUNCTIONAL is enabled by default.

[davidben, 2016-02-23 23:05:01]

Description was changed from

==========
Disable all NEON in BoringSSL if has_broken_neon is set.

Originally "broken NEON" and "no NEON" were separate states so that only the
poly1305 code would disable it. This ended up being set on only one CPU, so
rather than have to worry about whether the new NEON ChaCha20 and Poly1305 code
still triggers it, disable all BoringSSL NEON code.

This means we can remove the separate NEON bits in BoringSSL.

BUG=none
==========

to

==========
Disable all NEON in BoringSSL if has_broken_neon is set.

Originally "broken NEON" and "no NEON" were separate states so that only the
poly1305 code would disable it. This ended up being set on only one CPU, so
rather than have to worry about whether the new NEON ChaCha20 and Poly1305 code
still triggers it, disable all BoringSSL NEON code.

This means we can simplify BoringSSL's NEON state slightly.

BUG=589200
==========

[davidben, 2016-02-23 23:06:58]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2016-02-23 23:16:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1730823002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1730823002/1

[davidben, 2016-02-23 23:17:09]

The CQ bit was checked by davidben@chromium.org

[davidben, 2016-02-23 23:17:10]

The patchset sent to the CQ was uploaded after l-g-t-m from agl@chromium.org
Link to the patchset: https://codereview.chromium.org/1730823002/#ps20001
(title: "might help to land something that actually compiles...")

[commit-bot: I haz the power, 2016-02-23 23:23:28]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[commit-bot: I haz the power, 2016-02-23 23:24:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1730823002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1730823002/20001

[commit-bot: I haz the power, 2016-02-24 00:29:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 00:29:07]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[davidben, 2016-02-24 00:33:58]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2016-02-24 00:40:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1730823002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1730823002/20001

[commit-bot: I haz the power, 2016-02-24 01:39:43]

Description was changed from

==========
Disable all NEON in BoringSSL if has_broken_neon is set.

Originally "broken NEON" and "no NEON" were separate states so that only the
poly1305 code would disable it. This ended up being set on only one CPU, so
rather than have to worry about whether the new NEON ChaCha20 and Poly1305 code
still triggers it, disable all BoringSSL NEON code.

This means we can simplify BoringSSL's NEON state slightly.

BUG=589200
==========

to

==========
Disable all NEON in BoringSSL if has_broken_neon is set.

Originally "broken NEON" and "no NEON" were separate states so that only the
poly1305 code would disable it. This ended up being set on only one CPU, so
rather than have to worry about whether the new NEON ChaCha20 and Poly1305 code
still triggers it, disable all BoringSSL NEON code.

This means we can simplify BoringSSL's NEON state slightly.

BUG=589200
==========

[commit-bot: I haz the power, 2016-02-24 01:39:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-24 01:41:43]

Description was changed from

==========
Disable all NEON in BoringSSL if has_broken_neon is set.

Originally "broken NEON" and "no NEON" were separate states so that only the
poly1305 code would disable it. This ended up being set on only one CPU, so
rather than have to worry about whether the new NEON ChaCha20 and Poly1305 code
still triggers it, disable all BoringSSL NEON code.

This means we can simplify BoringSSL's NEON state slightly.

BUG=589200
==========

to

==========
Disable all NEON in BoringSSL if has_broken_neon is set.

Originally "broken NEON" and "no NEON" were separate states so that only the
poly1305 code would disable it. This ended up being set on only one CPU, so
rather than have to worry about whether the new NEON ChaCha20 and Poly1305 code
still triggers it, disable all BoringSSL NEON code.

This means we can simplify BoringSSL's NEON state slightly.

BUG=589200

Committed: https://crrev.com/396d38c7d55e1c039069017afd74488cac9060cd
Cr-Commit-Position: refs/heads/master@{#377180}
==========

[commit-bot: I haz the power, 2016-02-24 01:41:44]

Patchset 2 (id:??) landed as
https://crrev.com/396d38c7d55e1c039069017afd74488cac9060cd
Cr-Commit-Position: refs/heads/master@{#377180}