Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1730673002: Revert of Add WasmFrame, backtraces reflect wasm's presence (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add WasmFrame, backtraces reflect wasm's presence (patchset #9 id:160001 of https://codereview.chromium.org/1712003003/ ) Reason for revert: [Sheriff] Seems to break gcmole: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/8295 Original issue's description: > Add WasmFrame, backtraces reflect wasm's presence > > For now WasmFrame doesn't summarize the wasm frames. That'll require adding the > metadata in wasm-compiler similar to DeoptimizationInputData. > > Teach the basic backtrace to iterate over stack frames instead of JS frames. > > Update the wasm stack test. > > `git cl format` touches random lines in files I touch. > > R=titzer@chromium.org > TEST=d8 --test --expose-wasm test/mjsunit/mjsunit.js test/mjsunit/wasm/stack.js > > Committed: https://crrev.com/aeca945786dcccad3efecfddbf2c07aefa524a56 > Cr-Commit-Position: refs/heads/master@{#34220} TBR=titzer@chromium.org,mvstanton@chromium.org,mstarzinger@chromium.org,jfb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/943650784a39aabb1ae1419bb47130d1972b2dc2 Cr-Commit-Position: refs/heads/master@{#34221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -126 lines) Patch
M src/frames.h View 7 chunks +5 lines, -25 lines 0 comments Download
M src/frames.cc View 3 chunks +5 lines, -17 lines 0 comments Download
M src/frames-inl.h View 4 chunks +7 lines, -3 lines 0 comments Download
M src/isolate.cc View 3 chunks +44 lines, -75 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/stack.js View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
Created Revert of Add WasmFrame, backtraces reflect wasm's presence
4 years, 10 months ago (2016-02-23 18:55:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730673002/1
4 years, 10 months ago (2016-02-23 18:55:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 18:56:01 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/943650784a39aabb1ae1419bb47130d1972b2dc2 Cr-Commit-Position: refs/heads/master@{#34221}
4 years, 10 months ago (2016-02-23 18:57:31 UTC) #6
JF
4 years, 10 months ago (2016-02-23 19:12:37 UTC) #7
Message was sent while issue was closed.
Try to re-land in: https://codereview.chromium.org/1724063002

Powered by Google App Engine
This is Rietveld 408576698