Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1724063002: Add WasmFrame, backtraces reflect wasm's presence (Closed)

Created:
4 years, 10 months ago by JF
Modified:
4 years, 10 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add WasmFrame, backtraces reflect wasm's presence For now WasmFrame doesn't summarize the wasm frames. That'll require adding the metadata in wasm-compiler similar to DeoptimizationInputData. Teach the basic backtrace to iterate over stack frames instead of JS frames. Update the wasm stack test. `git cl format` touches random lines in files I touch. R=titzer@chromium.org TEST=d8 --test --expose-wasm test/mjsunit/mjsunit.js test/mjsunit/wasm/stack.js Originally landed in: https://codereview.chromium.org/1712003003/ Reverted in: https://codereview.chromium.org/1730673002/ This patch puts the JSFunction on the C++ stack. Committed: https://crrev.com/3c6a3ca7b01bc2a036196fdc241717f7cb3dc44c Cr-Commit-Position: refs/heads/master@{#34225}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -63 lines) Patch
M src/frames.h View 6 chunks +25 lines, -5 lines 0 comments Download
M src/frames.cc View 3 chunks +17 lines, -5 lines 0 comments Download
M src/frames-inl.h View 3 chunks +3 lines, -7 lines 0 comments Download
M src/isolate.cc View 3 chunks +75 lines, -44 lines 1 comment Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/stack.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
JF
4 years, 10 months ago (2016-02-23 19:11:37 UTC) #1
JF
https://codereview.chromium.org/1724063002/diff/1/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/1724063002/diff/1/src/isolate.cc#newcode432 src/isolate.cc:432: factory()->NewStringFromAsciiChecked("<WASM>")); This is different from the previous patch. The ...
4 years, 10 months ago (2016-02-23 19:14:32 UTC) #2
titzer
lgtm
4 years, 10 months ago (2016-02-23 19:15:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1724063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1724063002/1
4 years, 10 months ago (2016-02-23 19:17:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-23 19:38:54 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 19:39:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c6a3ca7b01bc2a036196fdc241717f7cb3dc44c
Cr-Commit-Position: refs/heads/master@{#34225}

Powered by Google App Engine
This is Rietveld 408576698