Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: extensions/renderer/api/display_source/wifi_display/wifi_display_session.h

Issue 1730583002: [chrome.displaySource] further implementation of call completion callbacks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments from Antony Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/api/display_source/wifi_display/wifi_display_session.h
diff --git a/extensions/renderer/api/display_source/wifi_display/wifi_display_session.h b/extensions/renderer/api/display_source/wifi_display/wifi_display_session.h
index 5d1030889d51f5bb93a0308c19b982f9f9bb1ed7..7eeb98786276295d5ad60224e19814f5d67b803b 100644
--- a/extensions/renderer/api/display_source/wifi_display/wifi_display_session.h
+++ b/extensions/renderer/api/display_source/wifi_display/wifi_display_session.h
@@ -21,24 +21,34 @@ class WiFiDisplaySession: public DisplaySourceSession,
~WiFiDisplaySession() override;
private:
+ using DisplaySourceSession::CompletionCallback;
// DisplaySourceSession overrides.
- void Start() override;
- void Terminate() override;
+ void Start(const CompletionCallback& callback) override;
+ void Terminate(const CompletionCallback& callback) override;
// WiFiDisplaySessionServiceClient overrides.
- void OnEstablished(const mojo::String& ip_address) override;
+ void OnConnected(const mojo::String& ip_address) override;
+ void OnConnectRequestHandled(bool success,
+ const mojo::String& error) override;
void OnTerminated() override;
+ void OnDisconnectRequestHandled(bool success,
+ const mojo::String& error) override;
void OnError(int32_t type, const mojo::String& description) override;
void OnMessage(const mojo::String& data) override;
// A connection error handler for the mojo objects used in this class.
void OnConnectionError();
+ void RunStartCallback(bool success, const std::string& error = "");
+ void RunTerminateCallback(bool success, const std::string& error = "");
+
private:
WiFiDisplaySessionServicePtr service_;
mojo::Binding<WiFiDisplaySessionServiceClient> binding_;
std::string ip_address_;
DisplaySourceSessionParams params_;
+ CompletionCallback start_completion_callback_;
+ CompletionCallback teminate_completion_callback_;
base::WeakPtrFactory<WiFiDisplaySession> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(WiFiDisplaySession);

Powered by Google App Engine
This is Rietveld 408576698