extensions/renderer/api/display_source/display_source_session.cc - Issue 1730583002: [chrome.displaySource] further implementation of call completion callbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api/display_source/display_source_session.cc

Issue 1730583002: [chrome.displaySource] further implementation of call completion callbacks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from Antony Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/renderer/api/display_source/display_source_session.h ('k') | extensions/renderer/api/display_source/wifi_display/wifi_display_session.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/api/display_source/display_source_session.cc

diff --git a/extensions/renderer/api/display_source/display_source_session.cc b/extensions/renderer/api/display_source/display_source_session.cc

index df830079b057bd9ff6509d101e3cdfc5dfe33bf6..20b14420dd93971e633bdb951240d8e5dca601fe 100644

--- a/extensions/renderer/api/display_source/display_source_session.cc

+++ b/extensions/renderer/api/display_source/display_source_session.cc

@@ -22,15 +22,12 @@ DisplaySourceSession::DisplaySourceSession()

DisplaySourceSession::~DisplaySourceSession() = default;

-void DisplaySourceSession::SetCallbacks(

- const SinkIdCallback& started_callback,

- const SinkIdCallback& terminated_callback,

+void DisplaySourceSession::SetNotificationCallbacks(

+ const base::Closure& terminated_callback,

const ErrorCallback& error_callback) {

- DCHECK(started_callback_.is_null());

DCHECK(terminated_callback_.is_null());

DCHECK(error_callback_.is_null());

- started_callback_ = started_callback;

terminated_callback_ = terminated_callback;

error_callback_ = error_callback;

}