[chrome.displaySource] further implementation of call completion callbacks

[chrome.displaySource] further implementation of call completion callbacks

The API implementation determines when and with which
arguments the 'startSession'/'terminateSession' completion
callbacks are invoked.

The 'exceeded_session_limit_error' session error type is
eliminated and substituted with 'startSession' completion
callback call (which is more natural since this problem is
detected before a new session is started).

JS bindings code is simplified.

BUG=242107
Committed: https://crrev.com/ef88b05837e968daf0389fce203c81dba16c17ed
Cr-Commit-Position: refs/heads/master@{#377864}

[Mikhail, 2016-02-23 17:36:23]

Description was changed from

==========
[chrome.displaySource] further implementation of call completion callbacks

The API implementation determines when and with which arguments the
'startSession'/'terminateSession' completion callbacks are invoked.

The 'exceeded_session_limit_error' session error is eliminated and
substituted with 'startSession' completion callback call (which is
more natural since the problem is detected before session is started).

JS bindings code is simplified.

BUG=242107
==========

to

==========
[chrome.displaySource] further implementation of call completion callbacks

The API implementation determines when and with which arguments the
'startSession'/'terminateSession' completion callbacks are invoked.

The 'exceeded_session_limit_error' session error is eliminated and
substituted with 'startSession' completion callback call (which is
more natural since the problem is detected before session is started).

JS bindings code is simplified.

BUG=242107
==========

[Mikhail, 2016-02-23 17:36:23]

mikhail.pozdnyakov@intel.com changed reviewers:
+ asargent@chromium.org

[Mikhail, 2016-02-23 17:39:17]

Description was changed from

==========
[chrome.displaySource] further implementation of call completion callbacks

The API implementation determines when and with which arguments the
'startSession'/'terminateSession' completion callbacks are invoked.

The 'exceeded_session_limit_error' session error is eliminated and
substituted with 'startSession' completion callback call (which is
more natural since the problem is detected before session is started).

JS bindings code is simplified.

BUG=242107
==========

to

==========
[chrome.displaySource] further implementation of call completion callbacks

The API implementation determines when and with which
arguments the 'startSession'/'terminateSession' completion
callbacks are invoked.

The 'exceeded_session_limit_error' session error type is
eliminated and substituted with 'startSession' completion callback call (which
is more natural since this problem is detected before a new session is started).

JS bindings code is simplified.

BUG=242107
==========

[Mikhail, 2016-02-23 17:39:37]

Description was changed from

==========
[chrome.displaySource] further implementation of call completion callbacks

The API implementation determines when and with which
arguments the 'startSession'/'terminateSession' completion
callbacks are invoked.

The 'exceeded_session_limit_error' session error type is
eliminated and substituted with 'startSession' completion callback call (which
is more natural since this problem is detected before a new session is started).

JS bindings code is simplified.

BUG=242107
==========

to

==========
[chrome.displaySource] further implementation of call completion callbacks

The API implementation determines when and with which
arguments the 'startSession'/'terminateSession' completion
callbacks are invoked.

The 'exceeded_session_limit_error' session error type is
eliminated and substituted with 'startSession' completion
callback call (which is more natural since this problem is
detected before a new session is started).

JS bindings code is simplified.

BUG=242107
==========

[Mikhail, 2016-02-23 17:40:11]

Please take a look

[asargent_no_longer_on_chrome, 2016-02-25 23:03:45]

lgtm

https://codereview.chromium.org/1730583002/diff/1/extensions/renderer/api/dis...
File extensions/renderer/api/display_source/wifi_display/wifi_display_session.h
(right):

https://codereview.chromium.org/1730583002/diff/1/extensions/renderer/api/dis...
extensions/renderer/api/display_source/wifi_display/wifi_display_session.h:42:
void RunStartCompletionCB(bool success, const std::string& error = "");
nit: the style guide states that names should avoid using abbreviation, so this
should be "RunStartCompletionCallback". (Could it be shorter? Having "Start" and
"Completion" together is slightly confusing, maybe "RunStartCallback" conveys
the same thing with one less word and less confusion?)

https://google.github.io/styleguide/cppguide.html#General_Naming_Rules

https://codereview.chromium.org/1730583002/diff/1/extensions/renderer/api/dis...
extensions/renderer/api/display_source/wifi_display/wifi_display_session.h:43:
void RunTerminateCompletionCB(bool success, const std::string& error = "");
same thing here (and maybe "RunTerminateCallback" would convey the right
meaning?)

[Mikhail, 2016-02-26 10:21:40]

Thanks for review!

https://codereview.chromium.org/1730583002/diff/1/extensions/renderer/api/dis...
File extensions/renderer/api/display_source/wifi_display/wifi_display_session.h
(right):

https://codereview.chromium.org/1730583002/diff/1/extensions/renderer/api/dis...
extensions/renderer/api/display_source/wifi_display/wifi_display_session.h:42:
void RunStartCompletionCB(bool success, const std::string& error = "");
On 2016/02/25 23:03:45, Antony Sargent wrote:
> nit: the style guide states that names should avoid using abbreviation, so
this
> should be "RunStartCompletionCallback". (Could it be shorter? Having "Start"
and
> "Completion" together is slightly confusing, maybe "RunStartCallback" conveys
> the same thing with one less word and less confusion?)
> 
> https://google.github.io/styleguide/cppguide.html#General_Naming_Rules

Done.

https://codereview.chromium.org/1730583002/diff/1/extensions/renderer/api/dis...
extensions/renderer/api/display_source/wifi_display/wifi_display_session.h:43:
void RunTerminateCompletionCB(bool success, const std::string& error = "");
On 2016/02/25 23:03:45, Antony Sargent wrote:
> same thing here (and maybe "RunTerminateCallback" would convey the right
> meaning?)
> 

Done.

[Mikhail, 2016-02-26 10:41:59]

The CQ bit was checked by mikhail.pozdnyakov@intel.com

[Mikhail, 2016-02-26 10:42:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/1730583002/#ps20001
(title: "Comments from Antony")

[commit-bot: I haz the power, 2016-02-26 10:42:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1730583002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1730583002/20001

[commit-bot: I haz the power, 2016-02-26 10:48:17]

Description was changed from

==========
[chrome.displaySource] further implementation of call completion callbacks

The API implementation determines when and with which
arguments the 'startSession'/'terminateSession' completion
callbacks are invoked.

The 'exceeded_session_limit_error' session error type is
eliminated and substituted with 'startSession' completion
callback call (which is more natural since this problem is
detected before a new session is started).

JS bindings code is simplified.

BUG=242107
==========

to

==========
[chrome.displaySource] further implementation of call completion callbacks

The API implementation determines when and with which
arguments the 'startSession'/'terminateSession' completion
callbacks are invoked.

The 'exceeded_session_limit_error' session error type is
eliminated and substituted with 'startSession' completion
callback call (which is more natural since this problem is
detected before a new session is started).

JS bindings code is simplified.

BUG=242107
==========

[commit-bot: I haz the power, 2016-02-26 10:48:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-26 10:49:12]

Description was changed from

==========
[chrome.displaySource] further implementation of call completion callbacks

The API implementation determines when and with which
arguments the 'startSession'/'terminateSession' completion
callbacks are invoked.

The 'exceeded_session_limit_error' session error type is
eliminated and substituted with 'startSession' completion
callback call (which is more natural since this problem is
detected before a new session is started).

JS bindings code is simplified.

BUG=242107
==========

to

==========
[chrome.displaySource] further implementation of call completion callbacks

The API implementation determines when and with which
arguments the 'startSession'/'terminateSession' completion
callbacks are invoked.

The 'exceeded_session_limit_error' session error type is
eliminated and substituted with 'startSession' completion
callback call (which is more natural since this problem is
detected before a new session is started).

JS bindings code is simplified.

BUG=242107

Committed: https://crrev.com/ef88b05837e968daf0389fce203c81dba16c17ed
Cr-Commit-Position: refs/heads/master@{#377864}
==========

[commit-bot: I haz the power, 2016-02-26 10:49:13]

Patchset 2 (id:??) landed as
https://crrev.com/ef88b05837e968daf0389fce203c81dba16c17ed
Cr-Commit-Position: refs/heads/master@{#377864}