Make nullable DOMString always treat undefined as null

Make nullable DOMString always treat undefined as null

According to the Web IDL spec[1] nullable types should convert
undefined to null (Step 2).

Behavior matches Firefox.

BUG=460722
[1] https://heycam.github.io/webidl/#es-nullable-type

Committed: https://crrev.com/41baf71318b7b2884c8741fad8aefad365554c1c
Cr-Commit-Position: refs/heads/master@{#378362}

[rwlbuis, 2016-02-25 19:41:20]

Description was changed from

==========
TreaatUndefinedAs WIP

BUG=
==========

to

==========
Make nullable types always treat undefined as null


Behavior matches FireFox.

BUG=460722
==========

[rwlbuis, 2016-02-25 19:47:17]

Description was changed from

==========
Make nullable types always treat undefined as null


Behavior matches FireFox.

BUG=460722
==========

to

==========
Make nullable types always treat undefined as null

According to the Web IDL spec[1] nullable types should convert undefined
to null (Step 2).

Behavior matches Firefox.

BUG=460722

[1] https://heycam.github.io/webidl/#es-nullable-type
==========

[rwlbuis, 2016-02-25 19:47:54]

rob.buis@samsung.com changed reviewers:
+ philipj@opera.com

[rwlbuis, 2016-02-25 19:47:55]

PTAL. May not be 100% the correct bug for this...

[philipj_slow, 2016-02-26 08:48:10]

philipj@opera.com changed reviewers:
+ bashi@chromium.org

[philipj_slow, 2016-02-26 08:48:10]

This makes sense and the changes look good to me, but this should be reviewed by
one of our bindings owners, adding bashi@.

Can you update the description to clarify that only strings are affected by
this? If other types already handle undefined correctly, note that as well.

[rwlbuis, 2016-02-26 20:05:26]

Description was changed from

==========
Make nullable types always treat undefined as null

According to the Web IDL spec[1] nullable types should convert undefined
to null (Step 2).

Behavior matches Firefox.

BUG=460722

[1] https://heycam.github.io/webidl/#es-nullable-type
==========

to

==========
Make nullable DOMString always treat undefined as null

According to the Web IDL spec[1] nullable types should convert undefined
to null (Step 2).

Behavior matches Firefox.

BUG=460722

[1] https://heycam.github.io/webidl/#es-nullable-type
==========

[rwlbuis, 2016-02-26 20:05:51]

Description was changed from

==========
Make nullable DOMString always treat undefined as null

According to the Web IDL spec[1] nullable types should convert undefined
to null (Step 2).

Behavior matches Firefox.

BUG=460722

[1] https://heycam.github.io/webidl/#es-nullable-type
==========

to

==========
Make nullable DOMString always treat undefined as null

According to the Web IDL spec[1] nullable types should convert
undefined to null (Step 2).

Behavior matches Firefox.

BUG=460722

[1] https://heycam.github.io/webidl/#es-nullable-type
==========

[rwlbuis, 2016-02-28 23:21:34]

On 2016/02/26 08:48:10, philipj_UTC7 wrote:
> This makes sense and the changes look good to me, but this should be reviewed
by
> one of our bindings owners, adding bashi@.
> 
> Can you update the description to clarify that only strings are affected by
> this? If other types already handle undefined correctly, note that as well.

Done!

[bashi, 2016-02-29 23:30:59]

Sorry for the late review. The change seems good.

https://codereview.chromium.org/1730323002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/imported/web-platform-tests/dom/nodes/Document-createElementNS-expected.txt
(left):

https://codereview.chromium.org/1730323002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imported/web-platform-tests/dom/nodes/Document-createElementNS-expected.txt:1:
This is a testharness.js-based test.
Could you explain why this is removed?

[rwlbuis, 2016-03-01 00:00:34]

On 2016/02/29 23:30:59, bashi1 wrote:
> Sorry for the late review. The change seems good.

No problem.

>
https://codereview.chromium.org/1730323002/diff/60001/third_party/WebKit/Layo...
> File
>
third_party/WebKit/LayoutTests/imported/web-platform-tests/dom/nodes/Document-createElementNS-expected.txt
> (left):
> 
>
https://codereview.chromium.org/1730323002/diff/60001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/imported/web-platform-tests/dom/nodes/Document-createElementNS-expected.txt:1:
> This is a testharness.js-based test.
> Could you explain why this is removed?

Yes, keeping this will get in the way of the git cl upload:

* The following files are passing testharness results without console error
messages, they should be removed:

.../src/third_party/WebKit/LayoutTests/imported/web-platform-tests/dom/nodes/Document-createElementNS-expected.txt
ERROR: found passing testharness results without console error messages.

[bashi, 2016-03-01 00:06:37]

Thanks for the clarification. LGTM.

[rwlbuis, 2016-03-01 00:08:11]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-03-01 00:08:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1730323002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1730323002/60001

[commit-bot: I haz the power, 2016-03-01 01:41:18]

Description was changed from

==========
Make nullable DOMString always treat undefined as null

According to the Web IDL spec[1] nullable types should convert
undefined to null (Step 2).

Behavior matches Firefox.

BUG=460722

[1] https://heycam.github.io/webidl/#es-nullable-type
==========

to

==========
Make nullable DOMString always treat undefined as null

According to the Web IDL spec[1] nullable types should convert
undefined to null (Step 2).

Behavior matches Firefox.

BUG=460722

[1] https://heycam.github.io/webidl/#es-nullable-type
==========

[commit-bot: I haz the power, 2016-03-01 01:41:19]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-01 01:42:32]

Description was changed from

==========
Make nullable DOMString always treat undefined as null

According to the Web IDL spec[1] nullable types should convert
undefined to null (Step 2).

Behavior matches Firefox.

BUG=460722

[1] https://heycam.github.io/webidl/#es-nullable-type
==========

to

==========
Make nullable DOMString always treat undefined as null

According to the Web IDL spec[1] nullable types should convert
undefined to null (Step 2).

Behavior matches Firefox.

BUG=460722

[1] https://heycam.github.io/webidl/#es-nullable-type

Committed: https://crrev.com/41baf71318b7b2884c8741fad8aefad365554c1c
Cr-Commit-Position: refs/heads/master@{#378362}
==========

[commit-bot: I haz the power, 2016-03-01 01:42:33]

Patchset 4 (id:??) landed as
https://crrev.com/41baf71318b7b2884c8741fad8aefad365554c1c
Cr-Commit-Position: refs/heads/master@{#378362}