Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

Issue 1730323002: Make nullable DOMString always treat undefined as null (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase test results Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
index 29215c45bb31abf581ba4e6172b93e3568a58f78..a9e9edabf6f588623c823cf5c0a18bcf122d34de 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
@@ -1607,7 +1607,7 @@ static void stringOrNullAttributeAttributeSetter(v8::Local<v8::Value> v8Value, c
{
v8::Local<v8::Object> holder = info.Holder();
TestObject* impl = V8TestObject::toImpl(holder);
- V8StringResource<TreatNullAsNullString> cppValue = v8Value;
+ V8StringResource<TreatNullAndUndefinedAsNullString> cppValue = v8Value;
if (!cppValue.prepare())
return;
impl->setStringOrNullAttribute(cppValue);
@@ -1742,7 +1742,7 @@ static void testEnumOrNullAttributeAttributeSetter(v8::Local<v8::Value> v8Value,
v8::Local<v8::Object> holder = info.Holder();
ExceptionState exceptionState(ExceptionState::SetterContext, "testEnumOrNullAttribute", "TestObject", holder, info.GetIsolate());
TestObject* impl = V8TestObject::toImpl(holder);
- V8StringResource<TreatNullAsNullString> cppValue = v8Value;
+ V8StringResource<TreatNullAndUndefinedAsNullString> cppValue = v8Value;
if (!cppValue.prepare())
return;
const char* validValues[] = {
@@ -2244,7 +2244,7 @@ static void cachedStringOrNoneAttributeAttributeSetter(v8::Local<v8::Value> v8Va
{
v8::Local<v8::Object> holder = info.Holder();
TestObject* impl = V8TestObject::toImpl(holder);
- V8StringResource<TreatNullAsNullString> cppValue = v8Value;
+ V8StringResource<TreatNullAndUndefinedAsNullString> cppValue = v8Value;
if (!cppValue.prepare())
return;
impl->setCachedStringOrNoneAttribute(cppValue);
@@ -7679,7 +7679,7 @@ static void voidMethodDefaultNullableByteStringArgMethod(const v8::FunctionCallb
{
ExceptionState exceptionState(ExceptionState::ExecutionContext, "voidMethodDefaultNullableByteStringArg", "TestObject", info.Holder(), info.GetIsolate());
TestObject* impl = V8TestObject::toImpl(info.Holder());
- V8StringResource<TreatNullAsNullString> defaultStringArg;
+ V8StringResource<TreatNullAndUndefinedAsNullString> defaultStringArg;
{
if (!info[0]->IsUndefined()) {
defaultStringArg = toByteString(info.GetIsolate(), info[0], exceptionState);
@@ -7700,7 +7700,7 @@ static void voidMethodDefaultNullableByteStringArgMethodCallback(const v8::Funct
static void voidMethodDefaultNullableStringArgMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
{
TestObject* impl = V8TestObject::toImpl(info.Holder());
- V8StringResource<TreatNullAsNullString> defaultStringArg;
+ V8StringResource<TreatNullAndUndefinedAsNullString> defaultStringArg;
{
if (!info[0]->IsUndefined()) {
defaultStringArg = info[0];

Powered by Google App Engine
This is Rietveld 408576698