Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: tracing/tracing/ui/analysis/single_user_expectation_sub_view.html

Issue 1730313007: Metric-ify SystemHealth metrics (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/model/user_model/user_expectation.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/ui/analysis/single_user_expectation_sub_view.html
diff --git a/tracing/tracing/ui/analysis/single_user_expectation_sub_view.html b/tracing/tracing/ui/analysis/single_user_expectation_sub_view.html
index 4bb0fc599548e5ae34a49e78432b638403871d76..886e1444fc026a08082ddc6f95542d2500000629 100644
--- a/tracing/tracing/ui/analysis/single_user_expectation_sub_view.html
+++ b/tracing/tracing/ui/analysis/single_user_expectation_sub_view.html
@@ -15,10 +15,6 @@ found in the LICENSE file.
<script>
'use strict';
- var ResponsivenessMetric = tr.metrics.sh.ResponsivenessMetric;
- var SystemHealthMetric = tr.metrics.sh.SystemHealthMetric;
- var EfficiencyMetric = tr.metrics.sh.EfficiencyMetric;
-
Polymer({
created: function() {
this.currentSelection_ = undefined;
@@ -47,27 +43,12 @@ found in the LICENSE file.
},
onCustomizeRows_: function(event) {
- var ir = this.selection[0];
-
- var metrics = [
- {name: 'Responsiveness', metric: ResponsivenessMetric},
- {name: 'Efficiency', metric: EfficiencyMetric}];
-
- metrics.forEach(function(spec) {
- var score = spec.metric.forExpectation(ir);
- if (score === undefined)
- return;
-
- event.rows.push({
- name: spec.name,
- value: tr.ui.b.toThreeDigitLocaleString(score)
- });
- });
+ var ue = this.selection[0];
- if (ir.rawCpuMs) {
+ if (ue.rawCpuMs) {
event.rows.push({
name: 'Total CPU',
- value: tr.v.ui.createScalarSpan(ir.totalCpuMs, {
+ value: tr.v.ui.createScalarSpan(ue.totalCpuMs, {
unit: tr.v.Unit.byName.timeDurationInMs
})
});
« no previous file with comments | « tracing/tracing/model/user_model/user_expectation.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698