tracing/tracing/model/user_model/user_expectation.html - Issue 1730313007: Metric-ify SystemHealth metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/model/user_model/user_expectation.html

Issue 1730313007: Metric-ify SystemHealth metrics (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/model/interaction_record_test.html ('k') | tracing/tracing/ui/analysis/single_user_expectation_sub_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/model/user_model/user_expectation.html

diff --git a/tracing/tracing/model/user_model/user_expectation.html b/tracing/tracing/model/user_model/user_expectation.html

index bd75a5d817f37814d9c5525891cf6448b8357c93..7be2319e9cf9a17770508315764d8633cd84c5e3 100644

--- a/tracing/tracing/model/user_model/user_expectation.html

+++ b/tracing/tracing/model/user_model/user_expectation.html

@@ -26,7 +26,8 @@ tr.exportTo('tr.model.um', function() {

this.parentModel = parentModel;

this.typeInfo_ = undefined;

- // sourceEvents are the ones that caused the IR Finder to create this IR.

+ // sourceEvents are the ones that caused the UserModelBuilder to create this

+ // UserExpectation.

this.sourceEvents = new tr.model.EventSet();

}

@@ -58,7 +59,8 @@ tr.exportTo('tr.model.um', function() {

get stableId() {

- return 'IR.' + this.parentModel.userModel.expectations.indexOf(this);

+ return ('UserExpectation.' +

+ this.parentModel.userModel.expectations.indexOf(this));

get typeInfo() {

@@ -95,7 +97,7 @@ tr.exportTo('tr.model.um', function() {

/**

- * Returns the sum of the number of CPU ms spent by this IR.

+ * Returns the sum of the number of CPU ms spent by this UserExpectation.

get totalCpuMs() {

var cpuMs = 0;