Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1730263002: Subzero: Add missing bits to MIPS implementation. (Closed)

Created:
4 years, 10 months ago by Jim Stichnoth
Modified:
4 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/IceInstMIPS32.h View 1 chunk +1 line, -1 line 2 comments Download
M src/IceInstMIPS32.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Jim Stichnoth
4 years, 10 months ago (2016-02-24 15:05:03 UTC) #3
Jim Stichnoth
Committed patchset #1 (id:1) manually as 09802a997a269e7509f8fc32ed9c6e026e61ff8e (presubmit successful).
4 years, 10 months ago (2016-02-24 15:05:16 UTC) #5
John
https://codereview.chromium.org/1730263002/diff/1/src/IceInstMIPS32.h File src/IceInstMIPS32.h (right): https://codereview.chromium.org/1730263002/diff/1/src/IceInstMIPS32.h#newcode322 src/IceInstMIPS32.h:322: // RelocOffset *OffsetReloc = nullptr; why? just remove the ...
4 years, 10 months ago (2016-02-24 15:11:19 UTC) #6
Jim Stichnoth
4 years, 10 months ago (2016-02-24 15:16:50 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1730263002/diff/1/src/IceInstMIPS32.h
File src/IceInstMIPS32.h (right):

https://codereview.chromium.org/1730263002/diff/1/src/IceInstMIPS32.h#newcode322
src/IceInstMIPS32.h:322: // RelocOffset *OffsetReloc = nullptr;
On 2016/02/24 15:11:19, John wrote:
> why? just remove the field if it is not used.

Leaving that for a separate cleanup CL - unfortunately I needed this fixed right
away...

Powered by Google App Engine
This is Rietveld 408576698