src/IceInstMIPS32.h - Issue 1730263002: Subzero: Add missing bits to MIPS implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstMIPS32.h

Issue 1730263002: Subzero: Add missing bits to MIPS implementation. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstMIPS32.h

diff --git a/src/IceInstMIPS32.h b/src/IceInstMIPS32.h

index 506ca6ec4980ccd8b87fa8886b1e79ac1b8c8bec..3037167ade4a9960735fca7ea58c4845b59f8182 100644

--- a/src/IceInstMIPS32.h

+++ b/src/IceInstMIPS32.h

@@ -319,7 +319,7 @@ public:

private:

InstMIPS32Label(Cfg *Func, TargetMIPS32 *Target);

- RelocOffset *OffsetReloc = nullptr;

+ // RelocOffset *OffsetReloc = nullptr;

John 2016/02/24 15:11:19 why? just remove the field if it is not used.

Jim Stichnoth 2016/02/24 15:16:50 Leaving that for a separate cleanup CL - unfortuna

SizeT Number; // used for unique label generation.

};

« no previous file with comments | « no previous file | src/IceInstMIPS32.cpp » ('j') | no next file with comments »