Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 173003003: android envsetup: Make passing --target-arch an error. (Closed)

Created:
6 years, 10 months ago by Nico
Modified:
6 years, 10 months ago
Reviewers:
Yaron
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

android envsetup: Make passing --target-arch an error. This is to make sure I found all the bots that used to pass this. I'll completely remove the flag in a day or two. Also remove the function for printing usage information. I accidentally removed processing for --help in r252034, but having a --help flag for printing --help as only supported flag is a bit silly anyways, so get rid of this. (Depends on https://codereview.chromium.org/170783015/ and https://chrome-internal-review.googlesource.com/#/c/155292/) BUG=330631 R=yfriedman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252166

Patch Set 1 #

Patch Set 2 : rietlol #

Patch Set 3 : selflol #

Patch Set 4 : rietlol2 #

Patch Set 5 : ! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M build/android/envsetup.sh View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M build/android/envsetup_functions.sh View 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
6 years, 10 months ago (2014-02-19 22:38:48 UTC) #1
Yaron
On 2014/02/19 22:38:48, Nico wrote: still seeing chunk mismatch
6 years, 10 months ago (2014-02-19 23:28:18 UTC) #2
Nico
On 2014/02/19 23:28:18, Yaron wrote: > On 2014/02/19 22:38:48, Nico wrote: > > still seeing ...
6 years, 10 months ago (2014-02-19 23:40:47 UTC) #3
Nico
Ok, patch set 5 has working side-by-side diffs. Patch set 4 has green try runs.
6 years, 10 months ago (2014-02-19 23:49:18 UTC) #4
Yaron
lgtm On Wed, Feb 19, 2014 at 3:49 PM, <thakis@chromium.org> wrote: > Ok, patch set ...
6 years, 10 months ago (2014-02-20 00:57:13 UTC) #5
Nico
6 years, 10 months ago (2014-02-20 03:33:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 manually as r252166 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698