Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2193)

Unified Diff: build/android/envsetup_functions.sh

Issue 173003003: android envsetup: Make passing --target-arch an error. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ! Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/envsetup.sh ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/envsetup_functions.sh
diff --git a/build/android/envsetup_functions.sh b/build/android/envsetup_functions.sh
index 083cdef22da7c625f0dda16ac653a6e976c06a0c..5d47276f3d06647cf03700e2b8d5fd5398cd8dc8 100755
--- a/build/android/envsetup_functions.sh
+++ b/build/android/envsetup_functions.sh
@@ -43,23 +43,16 @@ common_vars_defines() {
################################################################################
-# Prints out help message on usage.
-################################################################################
-print_usage() {
- echo "usage: ${0##*/} [--help]" >& 2
- echo "--help this help" >& 2
-}
-
-################################################################################
# Process command line options.
################################################################################
process_options() {
while [[ -n $1 ]]; do
case "$1" in
--target-arch=*)
- echo "WARNING: --target-arch is ignored and will be an error soon."
+ echo "ERROR: --target-arch is ignored."
echo "Pass -Dtarget_arch=foo to gyp instead."
echo "(x86 is spelled ia32 in gyp, mips becomes mipsel, arm stays arm)"
+ return 1
;;
*)
# Ignore other command line options
« no previous file with comments | « build/android/envsetup.sh ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698