[Offline pages] Adding the offline bolt light icon

[Offline pages] Adding the offline bolt light icon

Adds the light colored assets and properly displays them with dark themed pages or in incognito mode.

Icons for dark and light themes include alpha now, so alpha related code can be removed.

BUG=585209
R=tedchoc@chromium.org

Committed: https://crrev.com/4dc9b8a8957fd53f5954ed4f9413ff8a5a6f9f4b
Cr-Commit-Position: refs/heads/master@{#377941}

[fgorski, 2016-02-26 00:51:28]

Please take a look.

This does not address the animator problem, which is best solved by simply
getting correct assets.

[fgorski, 2016-02-26 17:14:43]

hold on. I got icons with alpha. I'll put them into this patch.

[fgorski, 2016-02-26 17:41:39]

Description was changed from

==========
[Offline pages] Adding the offline bolt light icon

Adds the light colored assets and properly displays them with dark
themed pages or in incognito mode.

BUG=585209
R=tedchoc@chromium.org
==========

to

==========
[Offline pages] Adding the offline bolt light icon

Adds the light colored assets and properly displays them with dark themed pages
or in incognito mode.

Icons for dark and light themes include alpha now, so alpha related code can be
removed.

BUG=585209
R=tedchoc@chromium.org
==========

[fgorski, 2016-02-26 17:42:18]

On 2016/02/26 17:14:43, fgorski wrote:
> hold on. I got icons with alpha. I'll put them into this patch.

PTAL. Patch is ready, animator problem is solved by icons including alpha, per
our yesterday's discussion.

[Ted C, 2016-02-26 17:58:58]

lgtm

https://codereview.chromium.org/1729683005/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
(right):

https://codereview.chromium.org/1729683005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java:1321:
: R.color.locationbar_light_verbose_status_color));
despite what git cl format tries to do, this should be 8 from the start of
getResources()

one thing I would try to do is put getResources() on the first line and see if
the whole ternary can fit on a the second line together.

https://codereview.chromium.org/1729683005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java:1326:
? R.color.locationbar_status_separator_color
-8 indent

[fgorski, 2016-02-26 18:12:40]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2016-02-26 18:12:40]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/1729683005/#ps40001
(title: "Fixing the spacing proposed by git cl format")

[fgorski, 2016-02-26 18:13:18]

Addressed.

https://codereview.chromium.org/1729683005/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
(right):

https://codereview.chromium.org/1729683005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java:1321:
: R.color.locationbar_light_verbose_status_color));
On 2016/02/26 17:58:58, Ted C wrote:
> despite what git cl format tries to do, this should be 8 from the start of
> getResources()
> 
> one thing I would try to do is put getResources() on the first line and see if
> the whole ternary can fit on a the second line together.

Done.

https://codereview.chromium.org/1729683005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java:1326:
? R.color.locationbar_status_separator_color
On 2016/02/26 17:58:58, Ted C wrote:
> -8 indent

Done.

[commit-bot: I haz the power, 2016-02-26 18:14:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1729683005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1729683005/40001

[commit-bot: I haz the power, 2016-02-26 19:27:48]

Description was changed from

==========
[Offline pages] Adding the offline bolt light icon

Adds the light colored assets and properly displays them with dark themed pages
or in incognito mode.

Icons for dark and light themes include alpha now, so alpha related code can be
removed.

BUG=585209
R=tedchoc@chromium.org
==========

to

==========
[Offline pages] Adding the offline bolt light icon

Adds the light colored assets and properly displays them with dark themed pages
or in incognito mode.

Icons for dark and light themes include alpha now, so alpha related code can be
removed.

BUG=585209
R=tedchoc@chromium.org
==========

[commit-bot: I haz the power, 2016-02-26 19:27:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-26 19:29:03]

Description was changed from

==========
[Offline pages] Adding the offline bolt light icon

Adds the light colored assets and properly displays them with dark themed pages
or in incognito mode.

Icons for dark and light themes include alpha now, so alpha related code can be
removed.

BUG=585209
R=tedchoc@chromium.org
==========

to

==========
[Offline pages] Adding the offline bolt light icon

Adds the light colored assets and properly displays them with dark themed pages
or in incognito mode.

Icons for dark and light themes include alpha now, so alpha related code can be
removed.

BUG=585209
R=tedchoc@chromium.org

Committed: https://crrev.com/4dc9b8a8957fd53f5954ed4f9413ff8a5a6f9f4b
Cr-Commit-Position: refs/heads/master@{#377941}
==========

[commit-bot: I haz the power, 2016-02-26 19:29:04]

Patchset 3 (id:??) landed as
https://crrev.com/4dc9b8a8957fd53f5954ed4f9413ff8a5a6f9f4b
Cr-Commit-Position: refs/heads/master@{#377941}