Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

Issue 1729683005: [Offline pages] Adding the offline bolt light icon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@omnibox-patch-1
Patch Set: Fixing the spacing proposed by git cl format Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/values/colors.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
index 9cf07f47317d78013aaa9b2421cd4ad806ca412a..47a8f13b29b4962cf71d588d82d11a660094a48c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
@@ -1290,14 +1290,13 @@ public class LocationBarLayout extends FrameLayout implements OnClickListener,
mNavigationButton.setImageDrawable(null);
break;
case OFFLINE:
- mNavigationButton.setImageResource(R.drawable.offline_bolt);
+ mNavigationButton.setImageResource(
+ mUseDarkColors ? R.drawable.offline_bolt : R.drawable.offline_bolt_light);
break;
default:
assert false;
}
- mNavigationButton.setAlpha(buttonType == NavigationButtonType.OFFLINE ? 0.54f : 1.0f);
-
if (mNavigationButton.getVisibility() != VISIBLE) {
mNavigationButton.setVisibility(VISIBLE);
}
@@ -1314,10 +1313,20 @@ public class LocationBarLayout extends FrameLayout implements OnClickListener,
private void updateVerboseStatusVisibility() {
boolean verboseStatusVisible =
mNavigationButtonType == NavigationButtonType.OFFLINE && !mUrlHasFocus;
+
int verboseStatusVisibility = verboseStatusVisible ? VISIBLE : GONE;
+
+ mVerboseStatusTextView.setTextColor(ApiCompatibilityUtils.getColor(getResources(),
+ mUseDarkColors ? R.color.locationbar_verbose_status_color
+ : R.color.locationbar_light_verbose_status_color));
mVerboseStatusTextView.setVisibility(verboseStatusVisibility);
- findViewById(R.id.location_bar_verbose_status_separator)
- .setVisibility(verboseStatusVisibility);
+
+ View separator = findViewById(R.id.location_bar_verbose_status_separator);
+ separator.setBackgroundColor(ApiCompatibilityUtils.getColor(getResources(), mUseDarkColors
+ ? R.color.locationbar_status_separator_color
+ : R.color.locationbar_light_status_separator_color));
+ separator.setVisibility(verboseStatusVisibility);
+
findViewById(R.id.location_bar_verbose_status_extra_space)
.setVisibility(verboseStatusVisibility);
}
« no previous file with comments | « chrome/android/java/res/values/colors.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698