Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1729613003: Remove FXSYS_Mul. (Closed)

Created:
4 years, 10 months ago by dsinclair
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove FXSYS_Mul. This define just multiples the two parameters together. Inline the *'s. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/2c8fad44315db58f5b3222161dcb699691dca904

Patch Set 1 #

Total comments: 9

Patch Set 2 : review feedback #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -125 lines) Patch
M core/include/fxcrt/fx_system.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 2 chunks +5 lines, -8 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 3 chunks +5 lines, -10 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 4 chunks +13 lines, -16 lines 0 comments Download
M core/src/fxge/dib/fx_dib_engine.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M core/src/fxge/ge/fx_ge_path.cpp View 4 chunks +11 lines, -11 lines 0 comments Download
M core/src/fxge/win32/fx_win32_gdipext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/agg23/agg_clip_liang_barsky.h View 1 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/agg23/agg_curves.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/agg23/agg_math.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/agg23/agg_math_stroke.h View 7 chunks +15 lines, -15 lines 0 comments Download
M xfa/src/fxgraphics/src/fx_graphics.cpp View 2 chunks +13 lines, -15 lines 0 comments Download
M xfa/src/fxgraphics/src/fx_path_generator.cpp View 4 chunks +11 lines, -13 lines 0 comments Download
M xfa/src/fxgraphics/src/pre.h View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dsinclair
PTAL.
4 years, 10 months ago (2016-02-23 19:54:17 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1729613003/diff/1/third_party/agg23/agg_clip_liang_barsky.h File third_party/agg23/agg_clip_liang_barsky.h (right): https://codereview.chromium.org/1729613003/diff/1/third_party/agg23/agg_clip_liang_barsky.h#newcode91 third_party/agg23/agg_clip_liang_barsky.h:91: *x++ = (T)(x1 + (deltax * tiny)); formatting ...
4 years, 10 months ago (2016-02-23 20:00:10 UTC) #3
dsinclair
https://codereview.chromium.org/1729613003/diff/1/third_party/agg23/agg_clip_liang_barsky.h File third_party/agg23/agg_clip_liang_barsky.h (right): https://codereview.chromium.org/1729613003/diff/1/third_party/agg23/agg_clip_liang_barsky.h#newcode91 third_party/agg23/agg_clip_liang_barsky.h:91: *x++ = (T)(x1 + (deltax * tiny)); On 2016/02/23 ...
4 years, 10 months ago (2016-02-23 20:20:06 UTC) #4
dsinclair
Committed patchset #3 (id:40001) manually as 2c8fad44315db58f5b3222161dcb699691dca904 (presubmit successful).
4 years, 10 months ago (2016-02-23 20:23:32 UTC) #6
Lei Zhang
4 years, 10 months ago (2016-02-23 20:44:40 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1729613003/diff/1/third_party/agg23/agg_curve...
File third_party/agg23/agg_curves.cpp (right):

https://codereview.chromium.org/1729613003/diff/1/third_party/agg23/agg_curve...
third_party/agg23/agg_curves.cpp:78: if ((d3 * d3) <=
On 2016/02/23 20:20:06, dsinclair wrote:
> On 2016/02/23 20:00:10, Lei Zhang wrote:
> > more formatting
> 
> This is git cl format.

:\ Line 82 doesn't line up with line 78.

Powered by Google App Engine
This is Rietveld 408576698