Remove FXSYS_Mul.

xfa/src/fxgraphics/src/fx_graphics.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include <memory>
 
 #include "xfa/src/fxgraphics/src/fx_path_generator.h"
 #include "xfa/src/fxgraphics/src/pre.h"
@@ skipping 953 matching lines @@
   FX_FLOAT end_y = _info._fillColor->_shading->_endPoint.y;
   CFX_DIBitmap bmp;
   bmp.Create(width, height, FXDIB_Argb);
   _renderDevice->GetDIBits(&bmp, 0, 0);
   int32_t pitch = bmp.GetPitch();
   FX_BOOL result = FALSE;
   switch (_info._fillColor->_shading->_type) {
     case FX_SHADING_Axial: {
       FX_FLOAT x_span = end_x - start_x;
       FX_FLOAT y_span = end_y - start_y;
-      FX_FLOAT axis_len_square =
-          FXSYS_Mul(x_span, x_span) + FXSYS_Mul(y_span, y_span);
+      FX_FLOAT axis_len_square = (x_span * x_span) + (y_span * y_span);
       for (int32_t row = 0; row < height; row++) {
         FX_DWORD* dib_buf = (FX_DWORD*)(bmp.GetBuffer() + row * pitch);
         for (int32_t column = 0; column < width; column++) {
           FX_FLOAT x = (FX_FLOAT)(column);
           FX_FLOAT y = (FX_FLOAT)(row);
-          FX_FLOAT scale = FXSYS_Div(
-              FXSYS_Mul(x - start_x, x_span) + FXSYS_Mul(y - start_y, y_span),
-              axis_len_square);
+          FX_FLOAT scale =
+              FXSYS_Div(((x - start_x) * x_span) + ((y - start_y) * y_span),
+                        axis_len_square);
           if (scale < 0) {
             if (!_info._fillColor->_shading->_isExtendedBegin) {
               continue;
             }
             scale = 0;
           } else if (scale > 1.0f) {
             if (!_info._fillColor->_shading->_isExtendedEnd) {
               continue;
             }
             scale = 1.0f;
           }
           int32_t index = (int32_t)(scale * (FX_SHADING_Steps - 1));
           dib_buf[column] = _info._fillColor->_shading->_argbArray[index];
         }
       }
       result = TRUE;
       break;
     }
     case FX_SHADING_Radial: {
       FX_FLOAT start_r = _info._fillColor->_shading->_beginRadius;
       FX_FLOAT end_r = _info._fillColor->_shading->_endRadius;
-      FX_FLOAT a = FXSYS_Mul(start_x - end_x, start_x - end_x) +
-                   FXSYS_Mul(start_y - end_y, start_y - end_y) -
-                   FXSYS_Mul(start_r - end_r, start_r - end_r);
+      FX_FLOAT a = ((start_x - end_x) * (start_x - end_x)) +
+                   ((start_y - end_y) * (start_y - end_y)) -
+                   ((start_r - end_r) * (start_r - end_r));
       for (int32_t row = 0; row < height; row++) {
         FX_DWORD* dib_buf = (FX_DWORD*)(bmp.GetBuffer() + row * pitch);
         for (int32_t column = 0; column < width; column++) {
           FX_FLOAT x = (FX_FLOAT)(column);
           FX_FLOAT y = (FX_FLOAT)(row);
-          FX_FLOAT b = -2 * (FXSYS_Mul(x - start_x, end_x - start_x) +
-                             FXSYS_Mul(y - start_y, end_y - start_y) +
-                             FXSYS_Mul(start_r, end_r - start_r));
-          FX_FLOAT c = FXSYS_Mul(x - start_x, x - start_x) +
-                       FXSYS_Mul(y - start_y, y - start_y) -
-                       FXSYS_Mul(start_r, start_r);
+          FX_FLOAT b = -2 * (((x - start_x) * (end_x - start_x)) +
+                             ((y - start_y) * (end_y - start_y)) +
+                             (start_r * (end_r - start_r)));
+          FX_FLOAT c = ((x - start_x) * (x - start_x)) +
+                       ((y - start_y) * (y - start_y)) - (start_r * start_r);
           FX_FLOAT s;
           if (a == 0) {
             s = (FXSYS_Div(-c, b));
           } else {
-            FX_FLOAT b2_4ac = FXSYS_Mul(b, b) - 4 * FXSYS_Mul(a, c);
+            FX_FLOAT b2_4ac = (b * b) - 4 * (a * c);
             if (b2_4ac < 0) {
               continue;
             }
             FX_FLOAT root = (FXSYS_sqrt(b2_4ac));
             FX_FLOAT s1, s2;
             if (a > 0) {
               s1 = FXSYS_Div(-b - root, 2 * a);
               s2 = FXSYS_Div(-b + root, 2 * a);
             } else {
               s2 = FXSYS_Div(-b - root, 2 * a);
@@ skipping 417 matching lines @@
     b3 = (int32_t)(i * bScale);
     _argbArray[i] =
         FXARGB_TODIB(FXARGB_MAKE((a1 + a3), (r1 + r3), (g1 + g3), (b1 + b3)));
   }
   return FX_ERR_Succeeded;
 }
 class CFX_Pause : public IFX_Pause {
  public:
   virtual FX_BOOL NeedToPauseNow() { return TRUE; }
 };