third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html - Issue 1729563002: Replace RTCErrorCallback with RTCPeerConnectionErrorCallback.

Side by Side Diff: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html

Issue 1729563002: Replace RTCErrorCallback with RTCPeerConnectionErrorCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add missing files Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../resources/js-test.js"></script>	4 <script src="../../resources/js-test.js"></script>

5 </head>	5 </head>

6 <body>	6 <body>

7 <script>	7 <script>

8 description("Tests RTCPeerConnection createOffer.");	8 description("Tests RTCPeerConnection createOffer.");

9	9

10 // Note: createOffer() calls in the test runner are successful if the	10 // Note: createOffer() calls in the test runner are successful if the

11 // voiceActivityDetection and iceRestart options are passed with a value of true .	11 // voiceActivityDetection and iceRestart options are passed with a value of true .

12 // In all other cases, createOffer() fails in the test runner.	12 // In all other cases, createOffer() fails in the test runner.

13	13

14 var pc = null;	14 var pc = null;

15	15

16 function dummy() {}	16 function dummy() {}

17	17

18 function requestFailed2(reason)	18 function requestFailed2(reason)
	philipj_slow 2016/02/24 08:14:03 s/reason/error/? s/reason/error/? Guido Urdaneta 2016/02/24 12:42:09 Done. Show quoted text On 2016/02/24 08:14:03, philipj_UTC7 wrote: > s/reason/error/? Done.
19 {	19 {

20 testPassed('requestFailed was called.');	20 testPassed('requestFailed was called.');

21	21

22 errorReason = reason;	22 window.error = reason;

23 shouldBe('errorReason', '"TEST_ERROR"');	23 shouldBe('error.name', '"OperationError"');
	philipj_slow 2016/02/24 08:14:03 Also check error.message, or perhaps error.toStrin Also check error.message, or perhaps error.toString() to prove that treating the new value as a string will work fine. Guido Urdaneta 2016/02/24 12:42:09 Done. Show quoted text On 2016/02/24 08:14:03, philipj_UTC7 wrote: > Also check error.message, or perhaps error.toString() to prove that treating the > new value as a string will work fine. Done.
24	24

25 shouldNotThrow("pc.createOffer(dummy, dummy);");	25 shouldNotThrow("pc.createOffer(dummy, dummy);");

26 shouldNotThrow("pc.createOffer(dummy, dummy, {});");	26 shouldNotThrow("pc.createOffer(dummy, dummy, {});");

27 shouldNotThrow("pc.createOffer(dummy, dummy, {voiceActivityDetection:false}) ;");	27 shouldNotThrow("pc.createOffer(dummy, dummy, {voiceActivityDetection:false}) ;");

28 shouldNotThrow("pc.createOffer(dummy, dummy, {iceRestart:true});");	28 shouldNotThrow("pc.createOffer(dummy, dummy, {iceRestart:true});");

29 shouldNotThrow("pc.createOffer(dummy, dummy, {voiceActivityDetection:false, iceRestart:true});");	29 shouldNotThrow("pc.createOffer(dummy, dummy, {voiceActivityDetection:false, iceRestart:true});");

30	30

31 // Deprecated.	31 // Deprecated.

32 shouldThrow("pc.createOffer(dummy, dummy, {offerToReceiveVideo:-1, offerToRe ceiveAudio:0});");	32 shouldThrow("pc.createOffer(dummy, dummy, {offerToReceiveVideo:-1, offerToRe ceiveAudio:0});");

33 shouldThrow("pc.createOffer(dummy, dummy, {offerToReceiveVideo:0, offerToRec eiveAudio:-1});");	33 shouldThrow("pc.createOffer(dummy, dummy, {offerToReceiveVideo:0, offerToRec eiveAudio:-1});");

(...skipping 25 matching lines...) Expand all Loading...
59 }	59 }

60	60

61 pc = new webkitRTCPeerConnection(null);	61 pc = new webkitRTCPeerConnection(null);

62 pc.createOffer(requestSucceeded1, requestFailed1, {voiceActivityDetection:true, iceRestart:true});	62 pc.createOffer(requestSucceeded1, requestFailed1, {voiceActivityDetection:true, iceRestart:true});

63	63

64 window.jsTestIsAsync = true;	64 window.jsTestIsAsync = true;

65 window.successfullyParsed = true;	65 window.successfullyParsed = true;

66 </script>	66 </script>

67 </body>	67 </body>

68 </html>	68 </html>

OLD	NEW