Issue 172953003: Mojo: Make MessageInTransit more opaque.

Issue 172953003: Mojo: Make MessageInTransit more opaque. (Closed)

Created:
6 years, 10 months ago by viettrungluu

Modified:
6 years, 10 months ago

Reviewers:
yzshen1

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Make MessageInTransit more opaque. Still more to do, but incremental change is less scary. R=yzshen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252128

Patch Set 2 : review comments #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -27 lines)			Patch
M	mojo/system/channel.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	mojo/system/message_in_transit.h	View	1	2 chunks	+17 lines, -5 lines	0 comments	Download
M	mojo/system/message_in_transit.cc	View	1	1 chunk	+12 lines, -6 lines	0 comments	Download
M	mojo/system/raw_channel_posix.cc	View		3 chunks	+7 lines, -8 lines	0 comments	Download
M	mojo/system/raw_channel_posix_unittest.cc	View		3 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

yzshen1

https://codereview.chromium.org/172953003/diff/1/mojo/system/message_in_transit.cc File mojo/system/message_in_transit.cc (right): https://codereview.chromium.org/172953003/diff/1/mojo/system/message_in_transit.cc#newcode71 mojo/system/message_in_transit.cc:71: memcpy(buffer, this, buffer_size); is it better to use main_buffer() ...

6 years, 10 months ago (2014-02-19 23:15:59 UTC) #2

viettrungluu

Thanks, ptal. https://codereview.chromium.org/172953003/diff/1/mojo/system/message_in_transit.cc File mojo/system/message_in_transit.cc (right): https://codereview.chromium.org/172953003/diff/1/mojo/system/message_in_transit.cc#newcode71 mojo/system/message_in_transit.cc:71: memcpy(buffer, this, buffer_size); On 2014/02/19 23:15:59, yzshen1 ...

6 years, 10 months ago (2014-02-19 23:23:36 UTC) #3

viettrungluu

6 years, 10 months ago (2014-02-19 23:59:44 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r252128 (presubmit successful).

Expand Messages | Collapse Messages