Mojo: Make MessageInTransit more opaque.

mojo/system/message_in_transit.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/system/message_in_transit.h"
 
 #include <string.h>
 
 #include <new>
 
@@ skipping 33 matching lines @@
 MessageInTransit* MessageInTransit::Create(Type type,
                                            Subtype subtype,
                                            const void* bytes,
                                            uint32_t num_bytes,
                                            uint32_t num_handles) {
   DCHECK_LE(num_bytes, kMaxMessageNumBytes);
   DCHECK_LE(num_handles, kMaxMessageNumHandles);
 
   const size_t data_size = num_bytes;
   const size_t size_with_header = sizeof(MessageInTransit) + data_size;
-  const size_t size_with_header_and_padding =
-      RoundUpMessageAlignment(size_with_header);
+  const size_t buffer_size = RoundUpMessageAlignment(size_with_header);
 
-  char* buffer = static_cast<char*>(
-      base::AlignedAlloc(size_with_header_and_padding, kMessageAlignment));
+  char* buffer = static_cast<char*>(base::AlignedAlloc(buffer_size,
+                                                       kMessageAlignment));
   // The buffer consists of the header (a |MessageInTransit|, constructed using
   // a placement new), followed by the data, followed by padding (of zeros).
   MessageInTransit* rv = new (buffer) MessageInTransit(
       static_cast<uint32_t>(data_size), type, subtype, num_bytes, num_handles);
   memcpy(buffer + sizeof(MessageInTransit), bytes, num_bytes);
-  memset(buffer + size_with_header, 0,
-         size_with_header_and_padding - size_with_header);
+  memset(buffer + size_with_header, 0, buffer_size - size_with_header);
   return rv;
 }
 
+MessageInTransit* MessageInTransit::Clone() const {
+  size_t buffer_size = main_buffer_size();
+  char* buffer = static_cast<char*>(base::AlignedAlloc(buffer_size,
+                                                       kMessageAlignment));
+  memcpy(buffer, this, buffer_size);

[yzshen1, 2014/02/19 23:15:59]

is it better to use main_buffer() here?

[viettrungluu, 2014/02/19 23:23:36]

Done.

+  return reinterpret_cast<MessageInTransit*>(buffer);
+}
+
 void MessageInTransit::Destroy() {
   // No need to call the destructor, since we're POD.
   base::AlignedFree(this);
 }
 
 MessageInTransit::MessageInTransit(uint32_t data_size,
                                    Type type,
                                    Subtype subtype,
                                    uint32_t num_bytes,
                                    uint32_t num_handles)
     : header_(data_size, type, subtype, kInvalidEndpointId, kInvalidEndpointId,
               num_bytes, num_handles) {
   DCHECK_GE(header()->data_size, header()->num_bytes);
 }
 
 }  // namespace system
 }  // namespace mojo