chrome/browser/ui/views/extensions/extension_popup.h - Issue 17293003: Reveal the top-of-window views upon opening an extension popup via a shortcut key in immersive mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_popup.h

Issue 17293003: Reveal the top-of-window views upon opening an extension popup via a shortcut key in immersive mode (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/extension_installed_bubble.cc ('k') | chrome/browser/ui/views/extensions/extension_popup.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_popup.h

diff --git a/chrome/browser/ui/views/extensions/extension_popup.h b/chrome/browser/ui/views/extensions/extension_popup.h

index f8b3237fdd628de32dde424c1ffde35e23246704..4fabbf222f6795f283ae06328bf11fb072423737 100644

--- a/chrome/browser/ui/views/extensions/extension_popup.h

+++ b/chrome/browser/ui/views/extensions/extension_popup.h

@@ -84,6 +84,9 @@ class ExtensionPopup : public views::BubbleDelegateView,

void OnDevToolsStateChanged(content::DevToolsAgentHost*, bool attached);

+ // The browser to which the popup is anchored to. Not owned.

msw 2013/06/20 18:10:40 nit: remove duplicate 'to'.

+ Browser* browser_;

// The contained host for the view.

scoped_ptr<extensions::ExtensionHost> extension_host_;