Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Side by Side Diff: chrome/browser/ui/views/extensions/extension_popup.h

Issue 17293003: Reveal the top-of-window views upon opening an extension popup via a shortcut key in immersive mode (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_POPUP_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_POPUP_H_
6 #define CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_POPUP_H_ 6 #define CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_POPUP_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "chrome/browser/extensions/extension_host.h" 10 #include "chrome/browser/extensions/extension_host.h"
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 extensions::ExtensionHost* host, 77 extensions::ExtensionHost* host,
78 views::View* anchor_view, 78 views::View* anchor_view,
79 views::BubbleBorder::Arrow arrow, 79 views::BubbleBorder::Arrow arrow,
80 ShowAction show_action); 80 ShowAction show_action);
81 81
82 // Show the bubble, focus on its content, and register listeners. 82 // Show the bubble, focus on its content, and register listeners.
83 void ShowBubble(); 83 void ShowBubble();
84 84
85 void OnDevToolsStateChanged(content::DevToolsAgentHost*, bool attached); 85 void OnDevToolsStateChanged(content::DevToolsAgentHost*, bool attached);
86 86
87 // The browser to which the popup is anchored to. Not owned.
msw 2013/06/20 18:10:40 nit: remove duplicate 'to'.
88 Browser* browser_;
89
87 // The contained host for the view. 90 // The contained host for the view.
88 scoped_ptr<extensions::ExtensionHost> extension_host_; 91 scoped_ptr<extensions::ExtensionHost> extension_host_;
89 92
90 // Flag used to indicate if the pop-up should open a devtools window once 93 // Flag used to indicate if the pop-up should open a devtools window once
91 // it is shown inspecting it. 94 // it is shown inspecting it.
92 bool inspect_with_devtools_; 95 bool inspect_with_devtools_;
93 96
94 content::NotificationRegistrar registrar_; 97 content::NotificationRegistrar registrar_;
95 98
96 base::Callback<void(content::DevToolsAgentHost*, bool)> devtools_callback_; 99 base::Callback<void(content::DevToolsAgentHost*, bool)> devtools_callback_;
97 100
98 DISALLOW_COPY_AND_ASSIGN(ExtensionPopup); 101 DISALLOW_COPY_AND_ASSIGN(ExtensionPopup);
99 }; 102 };
100 103
101 #endif // CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_POPUP_H_ 104 #endif // CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_POPUP_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698