[wasm] I added comparison operators to the Int64Lowering.

src/compiler/wasm-compiler.cc

Index: src/compiler/wasm-compiler.cc
diff --git a/src/compiler/wasm-compiler.cc b/src/compiler/wasm-compiler.cc
index 9b0692267a05353b248df2cf216b9717fe79bd2b..369b648253270a43a7680af46a26eb947dc6af82 100644
--- a/src/compiler/wasm-compiler.cc
+++ b/src/compiler/wasm-compiler.cc
@@ -509,13 +509,41 @@ Node* WasmGraphBuilder::Binop(wasm::WasmOpcode opcode, Node* left,
 // kExprI64Eq:
 // kExprI64Ne:
 // kExprI64LtS:
-// kExprI64LeS:
-// kExprI64LtU:
-// kExprI64LeU:
-// kExprI64GtS:
-// kExprI64GeS:
-// kExprI64GtU:
-// kExprI64GeU:
+    case wasm::kExprI64LtS:
+      op = m->Int64LessThan();
+      break;
+    // kExprI64LeS:

[titzer, 2016/02/24 17:41:35]

You can drop the comments from the cases.

[ahaas, 2016/02/25 11:56:08]

I added these comments to avoid merge conflicts. I will remove them all when I'm
done with the Int64Lowering. Is it okay if I leave the comments before and after
my change and only remove those comments within my changes?

+    case wasm::kExprI64LeS:
+      op = m->Int64LessThanOrEqual();
+      break;
+    // kExprI64LtU:
+    case wasm::kExprI64LtU:
+      op = m->Uint64LessThan();
+      break;
+    // kExprI64LeU:
+    case wasm::kExprI64LeU:
+      op = m->Uint64LessThanOrEqual();
+      break;
+    // kExprI64GtS:
+    case wasm::kExprI64GtS:
+      op = m->Int64LessThan();
+      std::swap(left, right);
+      break;
+    // kExprI64GeS:
+    case wasm::kExprI64GeS:
+      op = m->Int64LessThanOrEqual();
+      std::swap(left, right);
+      break;
+    // kExprI64GtU:
+    case wasm::kExprI64GtU:
+      op = m->Uint64LessThan();
+      std::swap(left, right);
+      break;
+    // kExprI64GeU:
+    case wasm::kExprI64GeU:
+      op = m->Uint64LessThanOrEqual();
+      std::swap(left, right);
+      break;
 
 // kExprI32ConvertI64:
 // kExprI64SConvertI32:
@@ -600,34 +628,6 @@ Node* WasmGraphBuilder::Binop(wasm::WasmOpcode opcode, Node* left,
       break;
     case wasm::kExprI64Ne:
       return Invert(Binop(wasm::kExprI64Eq, left, right));
-    case wasm::kExprI64LtS:
-      op = m->Int64LessThan();
-      break;
-    case wasm::kExprI64LeS:
-      op = m->Int64LessThanOrEqual();
-      break;
-    case wasm::kExprI64LtU:
-      op = m->Uint64LessThan();
-      break;
-    case wasm::kExprI64LeU:
-      op = m->Uint64LessThanOrEqual();
-      break;
-    case wasm::kExprI64GtS:
-      op = m->Int64LessThan();
-      std::swap(left, right);
-      break;
-    case wasm::kExprI64GeS:
-      op = m->Int64LessThanOrEqual();
-      std::swap(left, right);
-      break;
-    case wasm::kExprI64GtU:
-      op = m->Uint64LessThan();
-      std::swap(left, right);
-      break;
-    case wasm::kExprI64GeU:
-      op = m->Uint64LessThanOrEqual();
-      std::swap(left, right);
-      break;
 #endif
 
     case wasm::kExprF32CopySign: